lopper: assists: xlnx_overlay_dt: Refactor to use Lopper tree operations #661
+542
−261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace plat.buf() string manipulation with LopperTree/LopperNode APIs for generating device tree overlays. This improves maintainability and aligns with Lopper's architecture Key changes: - Use LopperTree operations (+, -, overlay_of()) instead of string buffers - Add helper functions - Implement proper phandle resolution via tree.resolve() - Add support for cortexa78-versalnet and short platform names - Remove complex tab/indentation tracking logic - Add comprehensive error handling and validation Signed-off-by: Aravind Thokala <aravind.thokala@amd.com>
Author
|
@onkarharsh , |
sathishkumar-amd
suggested changes
Dec 8, 2025
Signed-off-by: Aravind Thokala <aravind.thokala@amd.com>
Signed-off-by: Aravind Thokala <aravind.thokala@amd.com>
arthokal
changed the title
…nfiguration Rely on Lopper's built-in phandle learning instead of manually registering axistream-connected, pcs-handle, and remote_endpoint properties. Lopper automatically discovers phandle properties by scanning input DTS files for &label references during schema generation. This simplifies the code and automatically handles new driver properties with phandles. Signed-off-by: Aravind Thokala <aravind.thokala@amd.com>
arthokal
changed the title
Collaborator
|
Is this still WIP ? Do we think it is ready for merge ? |
Contributor
|
Hi @sathishkumar-amd / @kedareswararao , Please review this change once. I don't have the full awareness of the changes here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace plat.buf() string manipulation with LopperTree/LopperNode APIs for generating device tree overlays. This improves maintainability and aligns with Lopper's architecture
Key changes: