Skip to content

Completed Calcualtor #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Completed Calcualtor #20

wants to merge 4 commits into from

Conversation

@johnwangel
Copy link

No description provided.

jesse-copeland
jesse-copeland reviewed Jun 15, 2017
View reviewed changes
Copy link

@jesse-copeland jesse-copeland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one issue with code indentation.

calculator.js
if (typeof x !== 'number') {
throw new Error('Not a number!');
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything below the validate function is indented one too far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jesse-copeland jesse-copeland jesse-copeland left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnwangel @jesse-copeland