Open
Conversation
devmentor-pl
approved these changes
Aug 4, 2025
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Natalio,
Super 👍
Zostawiłem drobną uwagę do pierwszego zadania :)
01/app.js
Outdated
| @@ -0,0 +1,7 @@ | |||
| const time = new Date().toLocaleTimeString(); | |||
Owner
There was a problem hiding this comment.
Uważaj na miejsce "deklaracji" takiej zmiennej. To zadanie jest ok, ale jeśli np. funkcja showCurrentTime będzie uruchamiana dopiero po kliknięciu np. w button. To czas jaki zostanie pokazany to nie moment kliknięcie w button. Tylko moment załadowania strony (wtedy zapisujesz czas do zmiennej). Jeśli pobierzesz czas wew. funkcji to będzie bardziej elastyczne rozwiązanie (czas zostanie pobrany w momencie uruchomienia funkcji).
Author
There was a problem hiding this comment.
@devmentor-pl W zadaniu 04 poprawiłam podobny błąd, ale już nie wróciłam do zadania 01. Teraz już poprawiłam, będę o tym pamiętać!
| function sayHello(firstName) { | ||
| console.log(`Cześć ${firstName}!`); | ||
| } | ||
| sayHello("Natalia"); |
| return sum; | ||
| }; | ||
|
|
||
| console.log(sumNumbers(5)); |
| } | ||
| }, 5000); | ||
| }; | ||
| runTimer(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.