Skip to content

tasks done#154

Open
TetraMeister wants to merge 1 commit intodevmentor-pl:masterfrom
TetraMeister:master
Open

tasks done#154
TetraMeister wants to merge 1 commit intodevmentor-pl:masterfrom
TetraMeister:master

Conversation

@TetraMeister
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Łukaszu,

Zadanka są ok 👍
Myślę jednak, że zgubiła Cię "rutyna" - warto pamietać o deklaracji tj. const/let

console.log(date)
};

showTime(); No newline at end of file
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

};


sayHello("devmentor.pl"); No newline at end of file
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -0,0 +1,11 @@
sumNumbers = function (number) {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warto dodać const przed. Mamy wtedy zabezpieczenie przed nadpisaniem tej "zmiennej" :)

let counter = 0;

intervalId = setInterval(function () {
date = (new Date()).toLocaleTimeString();
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lepiej nie tworzyć zmiennych globalnych, dlatego warto dodać const

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants