feat: 거대한 뿔피리 OPEN API 스케쥴러 구현 #90

dev-ant · 2026-01-21T13:58:06Z

📋 상세 설명

Nexon Open API 기반의 ‘거대한 외침의 뿔피리’ 히스토리 수집 기능을 신규 추가
- 도메인 모델, 서비스, 스케줄러, 조회용 REST API까지 포함한 전체 기능을 구현
5분 주기 멀티 서버 데이터 수집 및 중복 데이터 방지 로직을 적용
- 서버별 데이터를 주기적으로 수집하면서 동일 데이터 저장을 방지해 정합성을 확보
DB 스키마 및 코드 품질 전반 개선
- server_name, date_register 컬럼 및 인덱스를 추가하고, Java import 컨벤션과 코드 포맷을 전면 정리
기존의 auction history scheduler 중복 제거 로직 오류 해결
- 기존에는 API 응답데이터와 DB 데이터가 중복이 있으면 fetch를 멈추고 API 응답데이터 전부를 저장함
- 이제는 date_auction_buy, auction_buy_id를 이용해서 중복을 제거하고 API 응답데이터를 저장하게 수정

📊 체크리스트

PR 제목이 형식에 맞나요 e.g. feat: PR을 등록한다
코드가 테스트 되었나요
문서는 업데이트 되었나요
불필요한 코드를 제거했나요
이슈와 라벨이 등록되었나요 이슈 미등록

github-actions · 2026-01-21T13:59:16Z

✅ 테스트 결과 for PR

Build: success

🧪 테스트 실행 with Gradle
📈 Coverage: -0.00%

📁 테스트 결과
📁 커버리지 보고서 (HTML)

codecov · 2026-01-21T13:59:24Z

Codecov Report

❌ Patch coverage is 14.22925% with 217 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ugle/application/scheduler/HornBugleScheduler.java	0.00%	74 Missing ⚠️
...ugle/domain/service/HornBugleDuplicateChecker.java	0.00%	41 Missing ⚠️
...rnBugle/infrastructure/client/HornBugleClient.java	0.00%	24 Missing ⚠️
...ornBugle/application/service/HornBugleService.java	0.00%	21 Missing ⚠️
...cture/persistence/HornBugleRepositoryPortImpl.java	0.00%	13 Missing ⚠️
...ernity/hornBugle/domain/enums/HornBugleServer.java	0.00%	11 Missing ⚠️
...nterfaces/rest/controller/HornBugleController.java	0.00%	11 Missing ⚠️
.../persistence/AuctionHistoryRepositoryPortImpl.java	0.00%	7 Missing ⚠️
...ntroller/TopCategoryDailyStatisticsController.java	0.00%	4 Missing ⚠️
...troller/TopCategoryWeeklyStatisticsController.java	0.00%	4 Missing ⚠️
... and 3 more

📢 Thoughts on this report? Let us know!

Copilot

Pull request overview

This pull request adds a new horn bugle history feature that collects and stores "거대한 외침의 뿔피리" (Horn of Great Cry) data from the Nexon Open API. The feature includes a scheduled job that fetches data every 5 minutes across multiple game servers, implements duplicate detection, and provides REST APIs for querying the history. Additionally, the PR includes extensive import statement reordering across the entire codebase to follow Java conventions (java imports first, then third-party, then project imports).

Changes:

New horn bugle feature with complete domain model, services, scheduler, and REST APIs
Database migration adding server_name and date_register columns with indexes
Import statement reorganization across 100+ files following Java conventions
Code formatting improvements (line breaks in javadocs, method parameters)

Reviewed changes

Copilot reviewed 122 out of 122 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
src/main/java/until/the/eternity/hornBugle/**	Complete horn bugle feature implementation with domain, service, scheduler, and API layers
src/main/resources/db/migration/V14__*.sql	Database migration for horn_bugle_world_history table enhancements
src/main/resources/application.yml	Configuration for horn bugle scheduler (cron, retries, delays)
src/main/java/until/the/eternity/config/SecurityConfig.java	Added /horn-bugle/** endpoint to permitted paths
Multiple test and source files	Import statement reordering and code formatting improvements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-21T14:02:38Z

src/main/java/until/the/eternity/hornBugle/application/service/HornBugleService.java

+package until.the.eternity.hornBugle.application.service;
+
+import java.time.Instant;
+import java.util.List;
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.springframework.data.domain.Page;
+import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
+import until.the.eternity.common.response.PageResponseDto;
+import until.the.eternity.hornBugle.domain.entity.HornBugleWorldHistory;
+import until.the.eternity.hornBugle.domain.enums.HornBugleServer;
+import until.the.eternity.hornBugle.domain.mapper.HornBugleMapper;
+import until.the.eternity.hornBugle.domain.repository.HornBugleRepositoryPort;
+import until.the.eternity.hornBugle.domain.service.HornBugleDuplicateChecker;
+import until.the.eternity.hornBugle.interfaces.external.dto.OpenApiHornBugleHistoryResponse;
+import until.the.eternity.hornBugle.interfaces.rest.dto.request.HornBuglePageRequestDto;
+import until.the.eternity.hornBugle.interfaces.rest.dto.response.HornBugleHistoryResponse;
+
+@Slf4j
+@Service
+@RequiredArgsConstructor
+public class HornBugleService {
+
+    private final HornBugleRepositoryPort repository;
+    private final HornBugleDuplicateChecker duplicateChecker;
+    private final HornBugleMapper mapper;
+
+    /**
+     * API 응답 데이터를 중복 제거 후 저장한다.
+     *
+     * @param server 서버 정보
+     * @param responses API 응답 데이터
+     * @return 저장된 건수
+     */
+    @Transactional
+    public int saveAll(HornBugleServer server, List<OpenApiHornBugleHistoryResponse> responses) {
+        if (responses == null || responses.isEmpty()) {
+            log.debug("[HornBugle] [{}] No data to save.", server.getServerName());
+            return 0;
+        }
+
+        // 중복 제거
+        List<OpenApiHornBugleHistoryResponse> filtered =
+                duplicateChecker.filterDuplicates(server, responses);
+
+        if (filtered.isEmpty()) {
+            log.debug(
+                    "[HornBugle] [{}] All data is duplicated. Nothing to save.",
+                    server.getServerName());
+            return 0;
+        }
+
+        // Entity 변환 및 저장
+        Instant registerTime = Instant.now();
+        List<HornBugleWorldHistory> entities =
+                filtered.stream().map(dto -> mapper.toEntity(dto, server, registerTime)).toList();
+
+        repository.saveAll(entities);
+
+        log.info("[HornBugle] [{}] Saved {} new records.", server.getServerName(), entities.size());
+
+        return entities.size();
+    }
+
+    /**
+     * 서버별 최신 N건 조회 (페이징)
+     *
+     * @param serverName 서버 이름 (선택 사항, null이면 전체 조회)
+     * @param pageRequest 페이지 요청 정보
+     * @return 페이징 응답
+     */
+    @Transactional(readOnly = true)
+    public PageResponseDto<HornBugleHistoryResponse> search(
+            String serverName, HornBuglePageRequestDto pageRequest) {
+
+        Page<HornBugleWorldHistory> page;
+
+        if (serverName != null && !serverName.isBlank()) {
+            page = repository.findByServerName(serverName, pageRequest.toPageable());
+        } else {
+            page = repository.findAll(pageRequest.toPageable());
+        }
+
+        Page<HornBugleHistoryResponse> responsePage = page.map(mapper::toResponse);
+
+        return PageResponseDto.of(responsePage);
+    }
+}


There is no test coverage for the new HornBugle feature. The repository contains comprehensive test coverage for similar features (e.g., AuctionHistoryServiceTest, ItemInfoServiceTest), but tests are missing for HornBugleService, HornBugleScheduler, HornBugleDuplicateChecker, and HornBugleController. Add test classes to maintain consistency with the project's testing standards.

Copilot · 2026-01-21T14:02:38Z

...esources/db/migration/V14__add_server_name_and_date_register_to_horn_bugle_world_history.sql

+ALTER TABLE horn_bugle_world_history
+    ADD COLUMN server_name VARCHAR(20) NOT NULL DEFAULT '' COMMENT '서버 이름 (류트, 만돌린, 하프, 울프)';


The migration adds columns with 'NOT NULL DEFAULT' constraints. The DEFAULT value for 'server_name' is an empty string '', which may not be semantically correct for existing data if the table already has records. If the table has existing data, consider a two-step migration: first add the column as nullable, update existing records with appropriate values, then add the NOT NULL constraint.

Copilot · 2026-01-21T14:02:38Z

src/main/java/until/the/eternity/hornBugle/application/scheduler/HornBugleScheduler.java

+                        maxRetries,
+                        delay);
+
+                Thread.sleep(delay);


The method uses Thread.sleep() in a Spring-managed component which can block the thread pool. While acceptable for a scheduler with controlled concurrency, this pattern should be documented or replaced with more resilient retry mechanisms from libraries like Spring Retry or Resilience4j that provide better thread management and don't block threads unnecessarily.

Copilot · 2026-01-21T14:02:39Z

src/main/java/until/the/eternity/hornBugle/interfaces/rest/controller/HornBugleController.java

+    @GetMapping
+    @Operation(summary = "뿔피리 히스토리 조회", description = "거대한 외침의 뿔피리 내역을 조회합니다. 서버별 또는 전체 조회가 가능합니다.")
+    public ResponseEntity<PageResponseDto<HornBugleHistoryResponse>> search(
+            @Parameter(description = "서버 이름 (류트, 만돌린, 하프, 울프). 미입력시 전체 조회")
+                    @RequestParam(required = false)
+                    String serverName,
+            @ParameterObject @ModelAttribute @Valid HornBuglePageRequestDto pageRequest) {
+        PageResponseDto<HornBugleHistoryResponse> result = service.search(serverName, pageRequest);
+        return ResponseEntity.ok(result);
+    }


Missing validation for the 'serverName' parameter. The method accepts any string value but the system only supports specific servers (류트, 만돌린, 하프, 울프) as defined in HornBugleServer enum. Invalid server names will return empty results without informing the user of the error. Consider validating the server name against the enum values and returning a 400 Bad Request with a clear error message for invalid values.

Copilot · 2026-01-21T14:02:39Z

src/main/java/until/the/eternity/hornBugle/domain/entity/HornBugleWorldHistory.java

@@ -1,30 +1,41 @@
 package until.the.eternity.hornBugle.domain.entity;


The package name 'hornBugle' uses camelCase, which is inconsistent with Java package naming conventions. All other packages in this project use lowercase (e.g., 'auctionhistory', 'iteminfo', 'metalwareinfo'). The package should be renamed to 'hornbugle' to maintain consistency and follow Java conventions.

Copilot · 2026-01-21T14:02:39Z

src/main/java/until/the/eternity/hornBugle/interfaces/rest/controller/HornBugleController.java

+    @PostMapping("/batch")
+    @Operation(summary = "뿔피리 히스토리 배치 실행", description = "모든 서버의 거대한 외침의 뿔피리 내역을 수집하여 저장합니다.")
+    public ResponseEntity<Void> triggerBatch() {
+        scheduler.fetchAndSaveHornBugleHistoryAll();
+        return ResponseEntity.ok().build();
+    }


The scheduler method 'fetchAndSaveHornBugleHistoryAll' is directly exposed via a POST endpoint without any authentication, authorization, or rate limiting checks. This could allow unauthorized users to trigger expensive batch operations repeatedly. Consider adding proper security controls, such as requiring admin privileges or implementing rate limiting at the endpoint level.

Copilot · 2026-01-21T14:02:39Z

src/main/java/until/the/eternity/hornBugle/domain/service/HornBugleDuplicateChecker.java

+    private String buildDuplicateKey(String characterName, String message) {
+        return characterName + "|" + message;
+    }


The duplicate detection key is constructed by concatenating characterName and message with a pipe separator. If either field contains the pipe character '|', this could lead to false duplicates or missed duplicates. Consider using a more robust approach such as creating a composite key object or using a delimiter that is guaranteed not to appear in the data.

Copilot · 2026-01-21T14:02:40Z

...esources/db/migration/V14__add_server_name_and_date_register_to_horn_bugle_world_history.sql

+-- 2. date_register 컬럼 추가 (수집 시각)
+ALTER TABLE horn_bugle_world_history
+    ADD COLUMN date_register DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP COMMENT '해당 뿔피리 내역을 수집한 시각';


The DATETIME column type is used for 'date_register', but the entity uses java.time.Instant which typically maps to TIMESTAMP. This mismatch could lead to timezone-related issues or precision loss. Consider using TIMESTAMP in the migration to match the entity field type, or change the entity to use LocalDateTime if DATETIME is intentional.

Copilot · 2026-01-21T14:02:40Z

src/main/java/until/the/eternity/hornBugle/domain/service/HornBugleDuplicateChecker.java

+        // 동일한 date_send를 가진 기존 데이터들의 (character_name + message) 조합을 조회
+        Set<String> existingKeys = buildExistingKeysForDateSend(serverName, latestDateSend);


The duplicate checker performs a database query inside a transaction that may contain hundreds of entities to save. This could lead to performance issues as the 'findByServerNameAndDateSend' query is executed for every batch save operation. Consider caching this result or moving the duplicate check outside the transaction boundary to improve performance.

Copilot

Pull request overview

Copilot reviewed 37 out of 37 changed files in this pull request and generated 14 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-21T15:27:16Z

src/main/java/until/the/eternity/hornBugle/application/scheduler/HornBugleScheduler.java

+    @Scheduled(cron = "${openapi.horn-bugle.cron:0 */5 * * * *}", zone = "Asia/Seoul")
+    public void fetchAndSaveHornBugleHistoryAll() {
+        log.info("[HornBugle] Starting Horn Bugle World History scheduler");
+
+        HornBugleServer[] servers = HornBugleServer.values();
+        int totalSavedCount = 0;
+        List<HornBugleServer> failedServers = new ArrayList<>();
+
+        for (int i = 0; i < servers.length; i++) {
+            HornBugleServer server = servers[i];
+            int savedCount = fetchAndSaveForServer(server);
+
+            if (savedCount < 0) {
+                failedServers.add(server);
+            } else {
+                totalSavedCount += savedCount;
+            }
+
+            // Rate Limit: 마지막 서버가 아니면 1초 대기
+            if (i < servers.length - 1) {
+                waitForRateLimit();
+            }
+        }
+
+        // 실패한 서버들 재시도
+        if (!failedServers.isEmpty()) {
+            log.info(
+                    "[HornBugle] Retrying {} failed servers: {}",
+                    failedServers.size(),
+                    failedServers);
+            totalSavedCount += retryFailedServers(failedServers);
+        }
+
+        log.info(
+                "[HornBugle] Horn Bugle World History scheduler completed. Total saved: {}",
+                totalSavedCount);
+    }


The scheduler method is not annotated with @transactional or @async, which means it runs on the default Spring scheduler thread pool. The method blocks with Thread.sleep() calls totaling potentially several seconds (4 servers * 1 second rate limit + retry delays). If other @scheduled methods exist with similar timing, they could be blocked. Consider using @async with a dedicated thread pool for this scheduler or refactoring to use non-blocking reactive patterns.

Copilot · 2026-01-21T15:27:16Z

src/main/java/until/the/eternity/hornBugle/application/scheduler/HornBugleScheduler.java

+    private int fetchAndSaveForServer(HornBugleServer server) {
+        try {
+            OpenApiHornBugleHistoryListResponse response =
+                    client.fetchHornBugleHistory(server).block();


The reactive WebClient call is being blocked with .block(), which defeats the purpose of using reactive programming. This blocking call could lead to thread exhaustion under high load. Since the scheduler already uses blocking patterns (Thread.sleep), consider either fully committing to reactive patterns with proper error handling (returning Mono/Flux and using reactive operators) or using a blocking HTTP client (RestClient) for consistency and clarity.

Suggested change

client.fetchHornBugleHistory(server).block();

client.fetchHornBugleHistory(server).toFuture().join();

Copilot · 2026-01-21T15:27:17Z

src/main/java/until/the/eternity/hornBugle/application/scheduler/HornBugleScheduler.java

+package until.the.eternity.hornBugle.application.scheduler;
+
+import lombok.RequiredArgsConstructor;
+import lombok.extern.slf4j.Slf4j;
+import org.springframework.beans.factory.annotation.Value;
+import org.springframework.scheduling.annotation.Scheduled;
+import org.springframework.stereotype.Component;
+import until.the.eternity.hornBugle.application.service.HornBugleService;
+import until.the.eternity.hornBugle.domain.enums.HornBugleServer;
+import until.the.eternity.hornBugle.infrastructure.client.HornBugleClient;
+import until.the.eternity.hornBugle.interfaces.external.dto.OpenApiHornBugleHistoryListResponse;
+import until.the.eternity.hornBugle.interfaces.external.dto.OpenApiHornBugleHistoryResponse;
+
+import java.util.ArrayList;
+import java.util.List;
+
+@Slf4j
+@Component
+@RequiredArgsConstructor
+public class HornBugleScheduler {
+
+    private final HornBugleClient client;
+    private final HornBugleService service;
+
+    private static final long RATE_LIMIT_DELAY_MS = 1000L;
+
+    @Value("${openapi.horn-bugle.max-retries:3}")
+    private int maxRetries;
+
+    @Value("${openapi.horn-bugle.retry-delay-ms:2000}")
+    private long retryDelayMs;
+
+    @Scheduled(cron = "${openapi.horn-bugle.cron:0 */5 * * * *}", zone = "Asia/Seoul")
+    public void fetchAndSaveHornBugleHistoryAll() {
+        log.info("[HornBugle] Starting Horn Bugle World History scheduler");
+
+        HornBugleServer[] servers = HornBugleServer.values();
+        int totalSavedCount = 0;
+        List<HornBugleServer> failedServers = new ArrayList<>();
+
+        for (int i = 0; i < servers.length; i++) {
+            HornBugleServer server = servers[i];
+            int savedCount = fetchAndSaveForServer(server);
+
+            if (savedCount < 0) {
+                failedServers.add(server);
+            } else {
+                totalSavedCount += savedCount;
+            }
+
+            // Rate Limit: 마지막 서버가 아니면 1초 대기
+            if (i < servers.length - 1) {
+                waitForRateLimit();
+            }
+        }
+
+        // 실패한 서버들 재시도
+        if (!failedServers.isEmpty()) {
+            log.info(
+                    "[HornBugle] Retrying {} failed servers: {}",
+                    failedServers.size(),
+                    failedServers);
+            totalSavedCount += retryFailedServers(failedServers);
+        }
+
+        log.info(
+                "[HornBugle] Horn Bugle World History scheduler completed. Total saved: {}",
+                totalSavedCount);
+    }
+
+    /**
+     * 서버별 API 호출 및 저장
+     *
+     * @param server 서버
+     * @return 저장된 건수 (-1: 실패)
+     */
+    private int fetchAndSaveForServer(HornBugleServer server) {
+        try {
+            OpenApiHornBugleHistoryListResponse response =
+                    client.fetchHornBugleHistory(server).block();
+
+            if (response == null || response.hornBugleWorldHistory() == null) {
+                log.warn("[HornBugle] [{}] Empty response from API", server.getServerName());
+                return 0;
+            }
+
+            List<OpenApiHornBugleHistoryResponse> histories = response.hornBugleWorldHistory();
+            int savedCount = service.saveAll(server, histories);
+
+            log.info(
+                    "[HornBugle] [{}] Fetched {} records, saved {} new records",
+                    server.getServerName(),
+                    histories.size(),
+                    savedCount);
+
+            return savedCount;
+        } catch (Exception e) {
+            log.error(
+                    "[HornBugle] [{}] Failed to fetch and save: {}",
+                    server.getServerName(),
+                    e.getMessage(),
+                    e);
+            return -1;
+        }
+    }
+
+    /**
+     * 실패한 서버들 재시도
+     *
+     * @param failedServers 실패한 서버 목록
+     * @return 재시도로 저장된 총 건수
+     */
+    private int retryFailedServers(List<HornBugleServer> failedServers) {
+        int totalSavedCount = 0;
+
+        for (HornBugleServer server : failedServers) {
+            int savedCount = retryForServer(server);
+            if (savedCount >= 0) {
+                totalSavedCount += savedCount;
+            }
+        }
+
+        return totalSavedCount;
+    }
+
+    /**
+     * 단일 서버 재시도 (지수 백오프)
+     *
+     * @param server 서버
+     * @return 저장된 건수 (-1: 최종 실패)
+     */
+    private int retryForServer(HornBugleServer server) {
+        for (int attempt = 1; attempt <= maxRetries; attempt++) {
+            try {
+                long delay = retryDelayMs * (long) Math.pow(2, attempt - 1);
+                log.info(
+                        "[HornBugle] [{}] Retry attempt {}/{}, waiting {}ms",
+                        server.getServerName(),
+                        attempt,
+                        maxRetries,
+                        delay);
+
+                Thread.sleep(delay);
+
+                int savedCount = fetchAndSaveForServer(server);
+                if (savedCount >= 0) {
+                    log.info(
+                            "[HornBugle] [{}] Retry successful on attempt {}",
+                            server.getServerName(),
+                            attempt);
+                    return savedCount;
+                }
+            } catch (InterruptedException e) {
+                log.error("[HornBugle] [{}] Retry interrupted", server.getServerName(), e);
+                Thread.currentThread().interrupt();
+                return -1;
+            }
+        }
+
+        log.error(
+                "[HornBugle] [{}] All {} retry attempts failed",
+                server.getServerName(),
+                maxRetries);
+        return -1;
+    }
+
+    private void waitForRateLimit() {
+        try {
+            log.debug("[HornBugle] Waiting {}ms for rate limit", RATE_LIMIT_DELAY_MS);
+            Thread.sleep(RATE_LIMIT_DELAY_MS);
+        } catch (InterruptedException e) {
+            log.error("[HornBugle] Rate limit wait interrupted", e);
+            Thread.currentThread().interrupt();
+        }
+    }
+}


The new HornBugle feature lacks test coverage. Given that the repository has comprehensive tests for other features (auctionhistory, iteminfo, etc.), tests should be added for the HornBugle functionality including scheduler logic, duplicate checking, service methods, controller endpoints, and repository operations.

Copilot · 2026-01-21T15:27:17Z

...n/java/until/the/eternity/hornBugle/interfaces/rest/dto/request/HornBuglePageRequestDto.java

+    public Pageable toPageable() {
+        int resolvedPage = this.page != null ? this.page - 1 : DEFAULT_PAGE - 1;
+        int resolvedSize = this.size != null ? this.size : DEFAULT_SIZE;
+
+        return PageRequest.of(
+                resolvedPage, resolvedSize, Sort.by(Sort.Direction.DESC, SORT_BY_DATE_SEND));
+    }


The toPageable() method converts a 1-based page number to a 0-based index by subtracting 1. However, if a user passes page=0 or a negative number, it will result in an invalid page index (-1 or less), which could cause unexpected behavior in Spring Data. The @min(1) validation should prevent this, but it would be safer to add defensive validation in the method itself or document the assumption clearly.

Copilot · 2026-01-21T15:27:18Z

src/main/java/until/the/eternity/hornBugle/domain/mapper/HornBugleMapper.java

+    @Mapping(target = "id", ignore = true)
+    @Mapping(target = "serverName", expression = "java(server.getServerName())")
+    @Mapping(target = "dateRegister", source = "registerTime")
+    @Mapping(target = "dateSend", expression = "java(dto.dateSend().plusSeconds(32400))")


The time zone conversion logic appears to hardcode adding 32400 seconds (9 hours) to convert from UTC to KST. This assumes the API always returns UTC timestamps, but the conversion should ideally be done using proper timezone APIs (e.g., ZonedDateTime) rather than manual offset addition. This approach is fragile because it doesn't account for daylight saving time changes (though Korea doesn't observe DST). Consider using dateSend().atZone(ZoneId.of("UTC")).withZoneSameInstant(ZoneId.of("Asia/Seoul")).toInstant() for clarity and maintainability.

Copilot · 2026-01-21T15:27:19Z

src/main/java/until/the/eternity/hornBugle/interfaces/rest/controller/HornBugleController.java

+    @PostMapping("/batch")
+    @Operation(summary = "뿔피리 히스토리 배치 실행", description = "모든 서버의 거대한 외침의 뿔피리 내역을 수집하여 저장합니다.")
+    public ResponseEntity<Void> triggerBatch() {
+        log.info("[HornBugle] Batch API triggered");
+        try {
+            scheduler.fetchAndSaveHornBugleHistoryAll();
+            log.info("[HornBugle] Batch API completed successfully");
+        } catch (Exception e) {
+            log.error("[HornBugle] Batch API failed: {}", e.getMessage(), e);
+            throw e;
+        }
+        return ResponseEntity.ok().build();
+    }


The batch endpoint at POST /horn-bugle/batch is publicly accessible without authentication (as configured in SecurityConfig), but it triggers a potentially expensive operation that collects data from external APIs for all servers. This could be abused to cause rate limit issues or excessive resource consumption. Consider adding authentication/authorization or rate limiting for this endpoint.

Copilot · 2026-01-21T15:27:20Z

src/main/java/until/the/eternity/hornBugle/interfaces/rest/controller/HornBugleController.java

+            @Parameter(description = "서버 이름 (류트, 만돌린, 하프, 울프). 미입력시 전체 조회")
+                    @RequestParam(required = false)
+                    String serverName,


The serverName parameter is accepted as a plain String without validation. Invalid server names should be rejected early with a clear error message. Consider validating against the HornBugleServer enum values or using @pattern validation to ensure only valid server names are accepted.

Copilot · 2026-01-21T15:27:20Z

...ava/until/the/eternity/hornBugle/infrastructure/persistence/HornBugleRepositoryPortImpl.java

+    private final HornBugleJpaRepository jpaRepository;
+    private final EntityManager em;
+
+    @Value("${spring.jpa.properties.hibernate.jdbc.batch_size:500}")


The batch size is hardcoded to default to 500 but the Hibernate batch_size configuration is set to 100 in application.yml. This mismatch could lead to confusion and suboptimal batch processing. The batch size should either use the same configuration property or be documented why a different value is appropriate for this specific use case.

Suggested change

@Value("${spring.jpa.properties.hibernate.jdbc.batch_size:500}")

@Value("${spring.jpa.properties.hibernate.jdbc.batch_size:100}")

Copilot · 2026-01-21T15:27:20Z

src/main/java/until/the/eternity/hornBugle/domain/entity/HornBugleWorldHistory.java

+@Table(
+        name = "horn_bugle_world_history",
+        indexes = {
+            @Index(
+                    name = "idx_horn_bugle_server_date_send",
+                    columnList = "server_name, date_send DESC"),
+            @Index(name = "idx_horn_bugle_date_send", columnList = "date_send DESC")
+        })


The @Index annotations in the @table definition will be ignored by JPA at runtime. These annotations only affect schema generation during bootstrap. Since the project uses Flyway for database migrations (V14__add_server_name_and_date_register_to_horn_bugle_world_history.sql), these index definitions should be removed from the entity class to avoid confusion and maintain a single source of truth for schema changes in the migration files.

Copilot · 2026-01-21T15:27:21Z

src/main/java/until/the/eternity/hornBugle/infrastructure/client/HornBugleClient.java

+                .onErrorResume(
+                        throwable -> {
+                            log.error(
+                                    "[HornBugle] Failed to fetch Nexon Open API Horn Bugle History API for server='{}': error='{}', message='{}'",
+                                    server.getServerName(),
+                                    throwable.getClass().getSimpleName(),
+                                    throwable.getMessage(),
+                                    throwable);
+                            return Mono.empty();
+                        });


When the API call fails, the error handler returns Mono.empty(), which makes it impossible for the caller to distinguish between a successful empty response and a failed request. This could lead to silent failures being treated as "no data available". Consider using Mono.error() to propagate the error or return a Result/Either type that can represent both success and failure states explicitly.

…_id 둘 다 사용하도록 로직 수정

Copilot

Pull request overview

Copilot reviewed 46 out of 46 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-23T03:52:40Z

...esources/db/migration/V14__add_server_name_and_date_register_to_horn_bugle_world_history.sql

+ALTER TABLE horn_bugle_world_history
+    ADD COLUMN server_name VARCHAR(20) NOT NULL DEFAULT '' COMMENT '서버 이름 (류트, 만돌린, 하프, 울프)';
+


This migration adds server_name as NOT NULL DEFAULT ''. For any existing horn_bugle_world_history rows created before this change, server_name will become an empty string and will not match any real server name, which can break server-scoped queries/dedup logic. Consider backfilling existing rows to a valid server value (if known), making the column nullable, or cleaning up legacy data as part of the migration.

Copilot · 2026-01-23T03:52:41Z

...the/eternity/auctionhistory/infrastructure/persistence/AuctionHistoryRepositoryPortImpl.java

+        Optional<Instant> latestDate = findLatestDateAuctionBuyBySubCategory(itemCategory);
+        if (latestDate.isEmpty()) {
+            return Optional.empty();
+        }
+        List<String> ids =
+                jpaRepository.findAuctionBuyIdsByLatestDateAndSubCategory(
+                        itemCategory.getTopCategory(), itemCategory.getSubCategory());
+        return Optional.of(new LatestDateWithIds(latestDate.get(), new HashSet<>(ids)));


findLatestDateWithIdsBySubCategory issues two separate queries: one for latestDate and another that re-computes max(dateAuctionBuy) internally. If new rows are inserted between these calls, you can return a latestDate that doesn't match the returned ID set, breaking duplicate detection. Consider returning both latestDate and IDs from a single query/transaction (or derive latestDate from the same query used to fetch IDs).

Suggested change

Optional<Instant> latestDate = findLatestDateAuctionBuyBySubCategory(itemCategory);

if (latestDate.isEmpty()) {

return Optional.empty();

}

List<String> ids =

jpaRepository.findAuctionBuyIdsByLatestDateAndSubCategory(

itemCategory.getTopCategory(), itemCategory.getSubCategory());

return Optional.of(new LatestDateWithIds(latestDate.get(), new HashSet<>(ids)));

String topCategory = itemCategory.getTopCategory();

String subCategory = itemCategory.getSubCategory();

List<Object[]> results =

em.createQuery(

"select a.dateAuctionBuy, a.id " +

"from AuctionHistory a " +

"where a.topCategory = :topCategory " +

"and a.subCategory = :subCategory " +

"and a.dateAuctionBuy = (" +

" select max(b.dateAuctionBuy) " +

" from AuctionHistory b " +

" where b.topCategory = :topCategory " +

" and b.subCategory = :subCategory" +

")",

Object[].class)

.setParameter("topCategory", topCategory)

.setParameter("subCategory", subCategory)

.getResultList();

if (results.isEmpty()) {

return Optional.empty();

}

Instant latestDate = (Instant) results.get(0)[0];

HashSet<String> ids = new HashSet<>();

for (Object[] row : results) {

ids.add((String) row[1]);

}

return Optional.of(new LatestDateWithIds(latestDate, ids));

dev-ant added 4 commits January 21, 2026 20:36

feat: hornbungle 컬럼 추가 flyway script 작성 및 엔티티 반영

963e686

feat: hornbugle repository 및 scheduler 구현

ec9f909

feat: hornbugle controller 구현

31ae842

fix: hornbugle expression에서 mapstrcut context 제거

eb7dec8

dev-ant requested a review from Copilot January 21, 2026 13:58

Copilot started reviewing on behalf of dev-ant January 21, 2026 13:58 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

dev-ant added 4 commits January 22, 2026 00:06

feat: logging xml 설정에 spring local profile 추가

6984b62

fix: hornbugle data_send UTC to KST 변경

ecae241

fix: optimize imports

ea781ed

docs: README 업데이트

70cc01f

dev-ant requested a review from Copilot January 21, 2026 15:18

Copilot started reviewing on behalf of dev-ant January 21, 2026 15:19 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

dev-ant added 2 commits January 23, 2026 12:43

fix: auction history duplicator 중복 제거 시 date_auction_buy, auction_buy…

80a2e43

…_id 둘 다 사용하도록 로직 수정

fix: optimize imports

7c51b5b

dev-ant requested a review from Copilot January 23, 2026 03:44

Copilot started reviewing on behalf of dev-ant January 23, 2026 03:45 View session

dev-ant added ✨feature 새로운 기능 추가 🔧fix 버그 해결 labels Jan 23, 2026

dev-ant changed the title ~~Feat/hornbugle scheduler~~ feat: 거대한 뿔피리 OPEN API 스케쥴러 구현 Jan 23, 2026

Copilot AI reviewed Jan 23, 2026

View reviewed changes

dev-ant merged commit bd9e9d7 into dev Jan 23, 2026
7 of 8 checks passed

dev-ant deleted the feat/hornbugle-scheduler branch January 23, 2026 03:54

		ALTER TABLE horn_bugle_world_history
		ADD COLUMN server_name VARCHAR(20) NOT NULL DEFAULT '' COMMENT '서버 이름 (류트, 만돌린, 하프, 울프)';

		@@ -1,30 +1,41 @@
		package until.the.eternity.hornBugle.domain.entity;

		// 동일한 date_send를 가진 기존 데이터들의 (character_name + message) 조합을 조회
		Set<String> existingKeys = buildExistingKeysForDateSend(serverName, latestDateSend);

	client.fetchHornBugleHistory(server).block();
	client.fetchHornBugleHistory(server).toFuture().join();

	@Value("${spring.jpa.properties.hibernate.jdbc.batch_size:500}")
	@Value("${spring.jpa.properties.hibernate.jdbc.batch_size:100}")

-        Optional<Instant> latestDate = findLatestDateAuctionBuyBySubCategory(itemCategory);
-        if (latestDate.isEmpty()) {
-            return Optional.empty();
-        }
-        List<String> ids =
-                jpaRepository.findAuctionBuyIdsByLatestDateAndSubCategory(
-                        itemCategory.getTopCategory(), itemCategory.getSubCategory());
-        return Optional.of(new LatestDateWithIds(latestDate.get(), new HashSet<>(ids)));
+        String topCategory = itemCategory.getTopCategory();
+        String subCategory = itemCategory.getSubCategory();
+        List<Object[]> results =
+                em.createQuery(
+                                "select a.dateAuctionBuy, a.id " +
+                                        "from AuctionHistory a " +
+                                        "where a.topCategory = :topCategory " +
+                                        "and a.subCategory = :subCategory " +
+                                        "and a.dateAuctionBuy = (" +
+                                        "   select max(b.dateAuctionBuy) " +
+                                        "   from AuctionHistory b " +
+                                        "   where b.topCategory = :topCategory " +
+                                        "   and b.subCategory = :subCategory" +
+                                        ")",
+                                Object[].class)
+                        .setParameter("topCategory", topCategory)
+                        .setParameter("subCategory", subCategory)
+                        .getResultList();
+        if (results.isEmpty()) {
+            return Optional.empty();
+        }
+        Instant latestDate = (Instant) results.get(0)[0];
+        HashSet<String> ids = new HashSet<>();
+        for (Object[] row : results) {
+            ids.add((String) row[1]);
+        }
+        return Optional.of(new LatestDateWithIds(latestDate, ids));

feat: 거대한 뿔피리 OPEN API 스케쥴러 구현 #90

feat: 거대한 뿔피리 OPEN API 스케쥴러 구현 #90

Uh oh!

Conversation

dev-ant commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📋 상세 설명

📊 체크리스트

Uh oh!

github-actions bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ 테스트 결과 for PR

Uh oh!

codecov bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

dev-ant commented Jan 21, 2026 •

edited

Loading

github-actions bot commented Jan 21, 2026 •

edited

Loading

codecov bot commented Jan 21, 2026 •

edited

Loading