Skip to content

add new run to check issue in description #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
n-h-n merged 3 commits into from
May 23, 2025
Merged

add new run to check issue in description #2

n-h-n merged 3 commits into from
May 23, 2025

Conversation

@saisravani20
Copy link
Contributor

@saisravani20 saisravani20 commented May 22, 2025

No description provided.

@saisravani20 saisravani20 requested a review from devrev-jo as a code owner May 22, 2025 06:22
n-h-n
n-h-n reviewed May 22, 2025
View reviewed changes
checks/check_pr_description.py Outdated
sys.exit(1)

pr_description = sys.argv[1]
check_description(pr_description) No newline at end of file
Copy link
Contributor

@n-h-n n-h-n May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: eof newline

Copy link
Contributor

@n-h-n n-h-n May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saisravani20 plz fix.

n-h-n
n-h-n previously approved these changes May 23, 2025
View reviewed changes
@n-h-n n-h-n dismissed their stale review May 23, 2025 03:22

nit

@n-h-n n-h-n merged commit 42a6afe into main May 23, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devrev-jo devrev-jo Awaiting requested review from devrev-jo devrev-jo is a code owner

1 more reviewer

@n-h-n n-h-n n-h-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saisravani20 @n-h-n