Skip to content

Conversation

@tetnaylin
Copy link
Contributor

Description 🧾

  • Added the backend implementation for the profile picture storage using the minio object store.
  • The implementation should verify whether the base64 encoding that is passed in is valid and should remove the old image when a new image or an empty string is passed in.
  • A new filename should be created for every new upload to minimise the likelihood of different files having the same file names.

Testing

  • Using an API client, we first send a get request via the guest login route. Then the following were tested using the session cookie:
    • Successfully uploading a valid base64 encoding profile picture and storing the profile picture url in the database.
    • Error cases for images that are not of MIME type jpg, jpeg or png.
    • Successful removal of the old profile picture when a new profile picture is passed in.
    • Successful removal of the user's current profile picture when an empty string is passed in.
  • Another get request via the guest login route is then sent to obtain a different session cookie. Then the following were tested using the new session cookie:
    • Similar behaviour without affecting any of the other profile pictures uploaded by other users.

Checklist

  • 📍 You have assigned yourself to this pull request.
  • 🔗 You have linked an issue to which this pull request closes.
  • 💭 Leave any relevant specific directions to reviewers.
  • 👀 No secrets in clear text in the pull request.
  • 🎟️ To categorise release notes, the pull request should be labelled with at least one of these labels:
    • feature: for application feature improvement or new features
    • bug: fixing something that previously wasn't working
    • dev: development-side related changes
    • docker: updates to the Docker code
    • setup: changes to the setup/infrastructure of the codebase
    • test: updates to internal testing

@tetnaylin tetnaylin self-assigned this Nov 5, 2025
@tetnaylin tetnaylin requested a review from a team as a code owner November 5, 2025 15:06
@tetnaylin tetnaylin added the 🍀 feature 🪴 New feature or request label Nov 5, 2025
@tetnaylin tetnaylin linked an issue Nov 5, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍀 feature 🪴 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding profile photos for logged in users

3 participants