Skip to content

fix(select): Show the option box when clicking in the chevron icon #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pawer13 merged 1 commit into from
Oct 30, 2025
Merged

fix(select): Show the option box when clicking in the chevron icon #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 1 addition & 29 deletions src/lib/components/Select/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,35 +104,6 @@ export const dropdownRenderSelect = (
</StyledSelectDropdown>
);

export const renderUnselectedOption = (option: any, searchValue: string, dataId: string) => {
if (searchValue !== '' && (![...searchValue].every((char) => char === '*' || char === ' ') || !searchValue.includes(ALL_CHARACTER))) {
const regex = getRegExpBasedOnInput(searchValue);
if (regex === false) {
return (
<StyledSpanOption data-testid={`option-span-${option.value}`} data-id={`${dataId}.option-span-${option.value}`} value={option as string}>
{option}
</StyledSpanOption>
);
}
const indices = findSubstringIndices(option as string, regex);
if (indices.start !== -1 && indices.end !== -1) {
return (
<StyledSpanOption data-testid={`option-span-${option}-bold`} data-id={`${dataId}.option-span-${option.value}-bold`} value={option as string}>
{[...option].map((letter, index) => {
const isBold = searchValue.includes(ALL_CHARACTER) ? index === indices.start || index === indices.end : index >= indices.start && index <= indices.end;
return isBold ? <b key={letter}>{letter}</b> : letter;
})}
</StyledSpanOption>
);
}
}
return (
<StyledSpanOption data-testid={`option-span-${option}`} value={option as string}>
{option}
</StyledSpanOption>
);
};

const isDisabledOption = (option: Option, selectedValues: Array<string | number>, pageSize?: number) => {
if (pageSize !== undefined) return selectedValues.length >= pageSize && !selectedValues.includes(option.value);
return option.disabled;
Expand Down Expand Up @@ -345,6 +316,7 @@ export const Select = withDataId(
optionRender={optionRender as (option: FlattenOptionData<BaseOptionType>, info: { index: number }) => React.ReactNode}
options={options}
loading={isLoading}
open={showDropdown}
placeholder={placeholder}
ref={(r) => {
ref.current = r;
Expand Down
17 changes: 2 additions & 15 deletions tests/Select.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ButtonPaginationSelector, getButtonText } from '@components/Select/ButtonPaginationSelector';
import { tagRenderButtonPagination, dropdownRenderSelect, renderUnselectedOption, Select } from '@components/Select/Select';
import { tagRenderButtonPagination, dropdownRenderSelect, Select } from '@components/Select/Select';
import { filterOption, getOptionsBySearch } from '@components/Select/selectUtils';
import { act, fireEvent, render, screen } from '@testing-library/react';
import { describe, expect, it, vitest } from 'vitest';
Expand Down Expand Up @@ -321,20 +321,7 @@ describe('Ancillary functions', () => {
expect(buttonSelectAll).toBeNull();
});
});
describe('renderUnselectedOption', () => {
it('should render an simple option when no search value', () => {
const option = 'Test 1';
render(renderUnselectedOption(option, '', 'dataId'));
const optionWrapper = screen.getByTestId('option-span-Test 1');
expect(optionWrapper).toBeTruthy();
});
it('should render an bold option when search value matches', () => {
const option = 'Test 1';
render(renderUnselectedOption(option, 'Test', 'dataId'));
const optionWrapper = screen.getByTestId('option-span-Test 1-bold');
expect(optionWrapper).toBeTruthy();
});
});

});

describe('Select', () => {
Expand Down