perf(crypto): CRP-1827 Add a cache for G2Prepared #7967
Merged
+134
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the benchmark results of the verify_multi_sig_individual and verify_multi_sig_combined benchmarks by approximately 5%. This also corrects an error introduced when the G2 point cache was introduced; it reported its cache statistics into the BLS signature verification cache instead of the metrics for the point cache.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the benchmark results of the verify_multi_sig_individual and verify_multi_sig_combined benchmarks by approximately 5%.
This also corrects an error introduced when the G2 point cache was introduced; it reported its cache statistics into the BLS signature verification cache instead of the metrics for the point cache.