Ability to specify the download directory for content#80
Open
svonidze wants to merge 4 commits intodfreelon:mainfrom
Open
Ability to specify the download directory for content#80svonidze wants to merge 4 commits intodfreelon:mainfrom
svonidze wants to merge 4 commits intodfreelon:mainfrom
Conversation
This update makes several modifications to the data importing scripts for better robustness and clarity. As a part of these changes, a new function for content download from TikTok was added to improve the overall import workflow. Here are the main changes: 1. Added better handling for JSON data retrieval from TikTok, 2. Modified existing functions to improve error messages and clarity, 3. Added additional path parameters to content saving functions, 4. Replaced existing content downloading library with a custom function to handle pulling content data from TikTok. These improvements will make the script more reliable and easier to use.
…files and consistent `None` returns Refactor `pyktok.py` to skip downloading if files already exist and ensure consistent use of `None` as return value.
Owner
|
Hi, I appreciate your efforts on this PR. I'll need some time to check your code, but in the meantime, a few comments:
TIA |
…ed dependencies This commit introduces an ARM64-compatible version of the pyktok package, specifically designed for Raspberry Pi. Key changes include: 1. New installation script (`install_arm64.sh`) for setting up the environment and dependencies. 2. Added `pyproject-arm64.toml` for managing project metadata and dependencies. 3. Comprehensive README_ARM64.md with installation instructions and usage guidelines. 4. New test script (`test_arm64.py`) to verify ARM64 compatibility. 5. Refactored core functionality in `pyktok_arm64.py` to replace incompatible dependencies with Selenium-based alternatives. These updates enhance the usability of pyktok on ARM64 architecture, addressing previous compatibility issues.
Owner
|
Hi, I just took a look at your new pushes. I'll test them and get back to you, thanks. |
Author
|
sorry, dont want to make a public push , made a PR in my repo |
Owner
|
Your changes look good, I'm just figuring out the best way to integrate them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.