feat(computer-control): add Linux support for Chrome for Testing #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable Chrome for Testing installation and detection on Linux systems. Changes: - scripts/setup-chrome-for-testing.sh: Detect OS and architecture, download appropriate platform binaries (linux64, linux-arm64) - diagnostics.rs: Add platform-specific Chrome search paths with current platform prioritized, support Linux Chrome for Testing locations Tested on Linux x86_64 with Chrome for Testing 144.0.7559.96 Co-Authored-By: Claude <noreply@anthropic.com>
Use character-based truncation instead of byte-based to properly handle non-ASCII characters in session IDs. Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable Chrome for Testing installation and detection on Linux systems, plus a UTF-8 session ID fix.
Changes
scripts/setup-chrome-for-testing.sh
Darwin/Linux) and architecture (arm64/x86_64)chrome-mac-arm64,chrome-mac-x64chrome-linux64,chrome-linux-arm64crates/g3-computer-control/src/webdriver/diagnostics.rs
#[cfg(target_os)]crates/g3-cli/src/interactive.rs
instead of byte-based to properly handle non-ASCII characters
Motivation
The Chrome installation script and diagnostics only supported macOS,
preventing Linux users from using g3's computer control features.
Testing
Tested on Linux x86_64 with Chrome for Testing 144.0.7559.96:
linux64binaries