Embeddedrespondfactory threading issue#16
Open
jwmach1 wants to merge 17 commits intodhanji:masterfrom
Open
Conversation
…stom status codes and the other goodies of Reply
…ositories to cerberus.local
… in the flashcache
…tifactory * create VelocityEngineProvider to create just one engine for all template compilations
…oject. I know I had this in here before
…ethod interceptors (DecorateWidget change)
…somehow missed this earlier)
…eTuple, (2) that EmbedWidget has only one EmbeddedRespondFactory and (3) the EmbeddedRespondFactory was keeping a final StringBuilderRespond object to pass as the delegate to the factoried EmbeddedRespond. So, if two requests come in for the same page, they end up sharing a StringBuilderRespond
Owner
|
Holy crap, this should never happen--thanks let me chase it down! |
Author
|
This pull request is messed up because I branched from the wrong spot. sorry. The next one will be better :) |
Owner
|
Hehe, OK, thanks! |
Owner
|
Do you have a fix for this yet? |
Author
|
I never got this pull request cleaned up. The Fix is changing one file -- I did not see any negative side effects to instantiating a new new -James On Fri, Apr 20, 2012 at 6:57 PM, dhanji <
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Guice Stage.PRODUCTION, and more than one request was being served by the same PageTuple, they ended up sharing the same StringBuilderRespond -- kaboom!
so I moved the private final Respond respond = new StringBuilderRespond(new Object()); declaration of EmbeddedRespondFactory into the get method. Hopefully this pull request reflects that one small change to EmbeddedRespondFactory.