feat: enable querying apps-bundle.json #1409
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
amcgee
approved these changes
Mar 5, 2025
Member
amcgee
left a comment
amcgee
left a comment
There was a problem hiding this comment.
Yeah, seems like a good workaround solution for now. Maybe leave it undocumented until we get some time to think it through some more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept; useful for getting versions of bundled apps -- usable by Dashboard to get plugin versions, and by Global Shell to get versions of the loaded apps
legacy::bundledAppsa good key for the resource?useDataQueryto other endpoints, but the logic here could definitely just beresource === 'legacy::bundledApps' ? 'dhis-web-apps/apps-bundle.json' : ...