Skip to content

refactor: [DHIS2-19134] use select dropdown from dhis2/ui #3992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eirikhaugstulen wants to merge 45 commits into
base: master
Choose a base branch
from
Open

refactor: [DHIS2-19134] use select dropdown from dhis2/ui #3992

eirikhaugstulen wants to merge 45 commits into from

Conversation

@eirikhaugstulen
Copy link
Contributor

@eirikhaugstulen eirikhaugstulen commented Mar 7, 2025 •
edited by atlassian bot
Loading

DHIS2-19134
Summary:

  • Refactor our forms to use ui-dropdown instead of our internal one

@eirikhaugstulen eirikhaugstulen added e2e-tests e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud labels Mar 7, 2025
@github-actions
Copy link

github-actions bot commented Mar 8, 2025 •
edited
Loading

🚀 Deployed on https://deploy-preview-3992.capture.netlify.dhis2.org

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 11, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
5 New issues
5 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@eirikhaugstulen eirikhaugstulen marked this pull request as ready for review March 12, 2025 11:18
@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner March 12, 2025 11:18
@eirikhaugstulen eirikhaugstulen marked this pull request as draft March 24, 2025 12:11
devin-ai-integration bot and others added 4 commits June 25, 2025 09:08
@devin-ai-integration @eirikhaugstulen
resolve: fix merge conflicts while preserving UI component migration …
61e5093 
…and master improvements

Co-Authored-By: Eirik <eirik.haugstulen@gmail.com>
@devin-ai-integration @eirikhaugstulen
fix: update remaining virtualized-select selector to single-select-in…
b5d8733 
…put in Cypress tests

Co-Authored-By: Eirik <eirik.haugstulen@gmail.com>
@devin-ai-integration @eirikhaugstulen
refactor: use optional chaining in SingleSelectField components to im…
93e9b9c 
…prove code quality

- Replace traditional conditional checks with optional chaining operator
- Addresses SonarCloud code smells for better readability and conciseness
- Updates SingleSelectField.component.js, withFocusHandler.js, and withTranslations.js

Co-Authored-By: Eirik <eirik.haugstulen@gmail.com>
@devin-ai-integration @eirikhaugstulen
fix: correct commit message format to follow conventional commit stan…
4a57927 
…dards

Previous commit used 'resolve:' prefix which is not in allowed conventional commit types.
This commit ensures compliance with project's commit message linting rules.

Co-Authored-By: Eirik <eirik.haugstulen@gmail.com>
devin-ai-integration bot added a commit that referenced this pull request Jun 25, 2025
@devin-ai-integration @eirikhaugstulen
fix: resolve focus handler issue in SingleSelectField by adding missi…
16a8871 
…ng CSS styles

- Add inputWrapperFocused and inputWrapperUnfocused CSS styles to SingleSelectField component
- Update component composition to use compose(withStyles(styles), withFocusHandler())
- Follow the same pattern as MultiSelectField for consistent focus state management
- Resolves issue where blue focus background persisted when moving away from component

Fixes focus handler issue reported by simonadomnisoru in PR #3992 comments

Co-Authored-By: Eirik <eirik.haugstulen@gmail.com>
@devin-ai-integration devin-ai-integration bot mentioned this pull request Jun 25, 2025
Closed
@henrikmv henrikmv self-assigned this Jul 2, 2025
@henrikmv henrikmv marked this pull request as ready for review July 2, 2025 10:15
@henrikmv henrikmv requested a review from simonadomnisoru July 2, 2025 10:15
simonadomnisoru
simonadomnisoru reviewed Jul 2, 2025
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few Cypress tests related to data-test="single-select-input" are failing. Could you take a look? Thank you!

@simonadomnisoru
Copy link
Contributor

simonadomnisoru commented Jul 7, 2025

Hi @henrikmv, the blur approach look good now 👏 ! Before moving this to QA, could you fix the 8 failing Cypress tests in SearchThroughAddRelationship.feature related to data-test="single-select-input"? Thanks!

@henrikmv henrikmv removed the testing label Dec 15, 2025
@henrikmv henrikmv added testing and removed testing labels Dec 19, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 19, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
5 New issues
3 New Code Smells (required ≤ 0)
2 New Bugs (required ≤ 0)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

Assignees

@henrikmv henrikmv

Labels

testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eirikhaugstulen @simonadomnisoru @henrikmv