-
Notifications
You must be signed in to change notification settings - Fork 8
feat: modular integration with ENACTS API #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…add to list of datasets on import page
…, force selected year ranges to fit inside dataset year range
…iri datasets hook
| } | ||
|
|
||
| const countMissing = (data) => { | ||
| // Note: for now we require that all missing values have been converted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karimbahgat Do you remember the background for adding this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cant remember if that was me, but it does ring a bell that its adding the nr of missing values to the importCount object which reports the results of the import after completion. Before we send it to DHIS2 for import we filter out the missiing/NaN values, I think because DHIS2 requires valid values, so this is a way to report how many were missing/NaN. There are various scenarios where the aggregation process results in missing/NaN values for some org units or time periods.
|
|
This work has been squashed into a new PR: #94 |




https://dhis2.atlassian.net/browse/CLIM-12