Skip to content

Conversation

@karimbahgat
Copy link
Collaborator

@karimbahgat karimbahgat commented Jun 30, 2025

  • Adding support to list available datasets and import data from the ENACTS API. No support yet for visualizing/exploring the data.
  • Builds on the PR from @yambanso to allow generic data sources/datasets/APIs other than Google Earth Engine, Updating the Climate application(Local data intergration)  #51 .
  • Relies on the DHIS2 Routes API to customize and authenticate against the API.
  • Although limited to the ENACTS API, the PR is written in a modular way that should allow following similar patterns to add support for other APIs.

https://dhis2.atlassian.net/browse/CLIM-12

@dhis2-bot dhis2-bot temporarily deployed to netlify October 28, 2025 12:34 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 28, 2025 12:47 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 28, 2025 13:04 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 28, 2025 14:02 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify October 28, 2025 14:20 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 26, 2025 11:29 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 27, 2025 16:08 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 27, 2025 19:06 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify December 11, 2025 08:44 Inactive
}

const countMissing = (data) => {
// Note: for now we require that all missing values have been converted
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karimbahgat Do you remember the background for adding this?

Copy link
Collaborator Author

@karimbahgat karimbahgat Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant remember if that was me, but it does ring a bell that its adding the nr of missing values to the importCount object which reports the results of the import after completion. Before we send it to DHIS2 for import we filter out the missiing/NaN values, I think because DHIS2 requires valid values, so this is a way to report how many were missing/NaN. There are various scenarios where the aggregation process results in missing/NaN values for some org units or time periods.

@dhis2-bot dhis2-bot temporarily deployed to netlify December 11, 2025 08:56 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify December 12, 2025 15:58 Inactive
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
14 New issues
2 New Critical Issues (required ≤ 0)
14 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@dhis2-bot dhis2-bot temporarily deployed to netlify December 12, 2025 19:15 Inactive
@jenniferarnesen
Copy link
Collaborator

This work has been squashed into a new PR: #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants