feat: add predictor list and run predictor form #722
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for dhis2-maintenance-app-beta failed.
|
Chisomchima
changed the title
tomzemp
approved these changes
Dec 17, 2025
Member
tomzemp
left a comment
tomzemp
left a comment
There was a problem hiding this comment.
Looks good! I left a couple of small comments (you can look over and see if you want to address them).
I think it would be nice if we consider updating the DefaultListActions to be able to insert an extra action. We have the pattern here, and we'll also have it for SQL Views, and it seems like we're duplicating some code from there for the purpose of getting an extra action item here. But we could consider that abstraction when tackling SQL views.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-12-16.at.08.30.10.mov