Open
Conversation
Conflicts: lib/rubix/models/host.rb lib/rubix/models/host_group.rb spec/requests/host_request_spec.rb spec/support/integration_helper.rb
Owner
|
This looks really good! I'm traveling at the moment and lacking for time. Give me about a week -- I will look over the code, run the test suite, and make sure this works in our production environment at Infochimps then I will release. Thanks so much for your help! |
Owner
|
ivan, your code looks great! going through it now, making sure all works in our production systems and then will release gem. give me a day or two to finish. |
Contributor
|
Any ETA on closing this pull request? |
|
Any advance on this one? I'm really interested to see rubix support for zabbix 2.0! |
Author
|
Guys, we in express42.com use this branch, it works just fine, you can try it. But now we migrate to zabbixapi gem, so i do not support this branch anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've fix almost all specs and related models (except for action_request and monitor/* stuff). Now it supports only Zabbix 2.0.4, and i don't test it with MySQL database, only PostgreSQL.