Skip to content

some platforms/builds don't accept listdir arg #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tumukei wants to merge 1 commit into
base: master
Choose a base branch
from
Open

some platforms/builds don't accept listdir arg #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion rshell/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,7 +740,10 @@ def get_stat(filename):
def listdir(dirname):
"""Returns a list of filenames contained in the named directory."""
import os
return os.listdir(dirname)
try:
return os.listdir(dirname)
except TypeError:
return os.listdir()
Copy link
Collaborator

@davehylands davehylands Nov 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to mention any known platforms which don't accept arguments.

Copy link
Author

@tumukei tumukei Nov 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Atleast nrf pca10056.



def listdir_matches(match):
Expand Down