Skip to content

Conversation

@Demirrr
Copy link
Member

@Demirrr Demirrr commented Nov 14, 2025

No description provided.

- Moved BaseConceptLearner and RefinementBasedConceptLearner to learners module
- Updated imports in celoe.py and drill.py to use local .base import
- Updated imports in concept_learner.py and executor.py to use new path
- Added base classes to learners/__init__.py for backward compatibility
- All imports verified and working correctly
- Moved ontolearn/concept_learner.py to ontolearn/learners/concept_learner.py
- Updated all imports from 'ontolearn.concept_learner' to 'ontolearn.learners'
- Added EvoLearner, CLIP, NCES, NCES2, ROCES to learners/__init__.py exports
- Updated documentation references to reflect new module structure
- Affected files: examples, tests, docs, and internal imports
@Demirrr Demirrr requested a review from alkidbaci November 14, 2025 08:22
@alkidbaci
Copy link
Collaborator

What I notice here is that EvoLearner, NCES, NCES2 and ROCES are still in the same module concept_learner.py. Wouldn't it be better if we split them into different modules?

@alkidbaci
Copy link
Collaborator

And I believe NERO does not stand for Neural Evolutionary Reinforcement Ontology learner

@Demirrr Demirrr merged commit 1503b2d into develop Nov 19, 2025
2 checks passed
@Demirrr Demirrr deleted the refactoring_learners branch November 19, 2025 10:00
@github-actions github-actions bot temporarily deployed to pull request November 19, 2025 10:00 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants