Skip to content

Conversation

@alkidbaci
Copy link
Collaborator

@alkidbaci alkidbaci commented Nov 17, 2025

  • Refactoring due to integration with owlapy 1.6.2 and dicee 0.2.0
  • Serve script for EBR ontolearn/scripts/litserve_neural_reasoner.py is moved to owlapy
  • README update: improved clarity

@alkidbaci alkidbaci requested a review from Demirrr November 18, 2025 10:19
@Demirrr
Copy link
Member

Demirrr commented Nov 18, 2025

Thank you for the PR. I will review it tomorrow:)

@alkidbaci alkidbaci requested a review from Copilot November 19, 2025 10:52
Copilot finished reviewing on behalf of alkidbaci November 19, 2025 10:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project to owlapy 1.6.2 and dicee 0.2.0, refactoring code to use the new API patterns. The neural reasoner serving script is moved to the owlapy package, and the README is improved for clarity.

Key changes:

  • Replace TripleStoreNeuralReasoner with EBR(NeuralOntology(...)) pattern throughout the codebase
  • Update imports from ontolearn to owlapy for neural reasoning functionality
  • Upgrade dependency versions and relax torch version constraint from ==2.2.0 to >=2.2.0

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
setup.py Updates dependency versions: owlapy 1.5.1→1.6.2, dicee 0.1.4→0.2.0, torch constraint relaxed
ontolearn/triple_store.py Fixes typo: reminderremainder for IRI property access
ontolearn/semantic_caching.py Migrates from TripleStoreNeuralReasoner to EBR(NeuralOntology(...))
ontolearn/scripts/litserve_neural_reasoner.py Removes entire file (moved to owlapy)
ontolearn/learners/nces2.py Improves file handling with absolute paths and mode 'w' instead of 'a'
ontolearn/learners/nces.py Updates dicee version, improves file handling, adds debugging output
ontolearn/learners/celoe.py Renames import: OperandSetTransformCESimplifier
ontolearn/learners/base.py Extends type checking to include TripleStoreOntology
examples/concept_learning_neural_evaluation.py Migrates to new neural reasoner API
tests/test_example_concept_learning_neural_evaluation.py Updates test code (commented) with new API
tests/test_base_concept_learner.py Removes unused tempfile import
README.md Improves webservice documentation with clearer structure and examples
.coveragerc Adds explicit source directive for coverage configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alkidbaci
Copy link
Collaborator Author

@Demirrr ready for your review

Copy link
Member

@Demirrr Demirrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR :)

@Demirrr Demirrr merged commit 61fa5c0 into develop Nov 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants