-
Notifications
You must be signed in to change notification settings - Fork 12
Upgrade to owlapy 1.6.2 #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for the PR. I will review it tomorrow:) |
…1.6.2 # Conflicts: # ontolearn/concept_learner.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the project to owlapy 1.6.2 and dicee 0.2.0, refactoring code to use the new API patterns. The neural reasoner serving script is moved to the owlapy package, and the README is improved for clarity.
Key changes:
- Replace
TripleStoreNeuralReasonerwithEBR(NeuralOntology(...))pattern throughout the codebase - Update imports from ontolearn to owlapy for neural reasoning functionality
- Upgrade dependency versions and relax torch version constraint from
==2.2.0to>=2.2.0
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Updates dependency versions: owlapy 1.5.1→1.6.2, dicee 0.1.4→0.2.0, torch constraint relaxed |
| ontolearn/triple_store.py | Fixes typo: reminder → remainder for IRI property access |
| ontolearn/semantic_caching.py | Migrates from TripleStoreNeuralReasoner to EBR(NeuralOntology(...)) |
| ontolearn/scripts/litserve_neural_reasoner.py | Removes entire file (moved to owlapy) |
| ontolearn/learners/nces2.py | Improves file handling with absolute paths and mode 'w' instead of 'a' |
| ontolearn/learners/nces.py | Updates dicee version, improves file handling, adds debugging output |
| ontolearn/learners/celoe.py | Renames import: OperandSetTransform → CESimplifier |
| ontolearn/learners/base.py | Extends type checking to include TripleStoreOntology |
| examples/concept_learning_neural_evaluation.py | Migrates to new neural reasoner API |
| tests/test_example_concept_learning_neural_evaluation.py | Updates test code (commented) with new API |
| tests/test_base_concept_learner.py | Removes unused tempfile import |
| README.md | Improves webservice documentation with clearer structure and examples |
| .coveragerc | Adds explicit source directive for coverage configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Demirrr ready for your review |
Demirrr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR :)
owlapy 1.6.2anddicee 0.2.0ontolearn/scripts/litserve_neural_reasoner.pyis moved to owlapy