Skip to content

Conversation

@briandowns
Copy link
Contributor

@briandowns briandowns commented Sep 30, 2024

Datetime Module

What's Changed:

Refactor Datetime module to be class based and add additional features. This is marked as draft / WIP in order to get feedback on the implementation. If acceptable, I'll complete this with docs, tests, etc, as well as squash the commits down some more.

I added a "duration" object but I'm wanting to rethink it some. I can add that functionality in another PR.

Type of Change:

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • Tests have been updated to reflect the changes done within this PR (if applicable).
  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
@briandowns briandowns self-assigned this Sep 30, 2024
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
@Jason2605
Copy link
Member

Sorry I've been slow on this! Looks as though all the tests are failing so we will need to look into these!

@briandowns
Copy link
Contributor Author

I'll get them passing. Just wanted to make sure the approach is ok.

@Jason2605
Copy link
Member

Ah apologies mate! Yeah I like it, an object wrapper around the long value seems sensible to me :)

Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants