Skip to content

Conversation

@zmx27
Copy link
Collaborator

@zmx27 zmx27 commented Nov 1, 2025

No description provided.

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.04%. Comparing base (a3589f3) to head (a962472).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   75.67%   78.04%   +2.37%     
==========================================
  Files           3        4       +1     
  Lines          37       41       +4     
==========================================
+ Hits           28       32       +4     
  Misses          9        9              
Files with missing lines Coverage Δ
tests/test_version_confutils.py 100.00% <ø> (ø)
tests/test_version_planargui.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zmx27
Copy link
Collaborator Author

zmx27 commented Nov 1, 2025

@sbillinge ready for review.

@sbillinge
Copy link
Contributor

Ahh that is a lot of gui code. Maybe this want such a good idea. I wonder if we should move it instead into xpdfsuite itself, or just make it public itself. What do you think? Is it possible to run this code separate from xpdfsuite? If so. I suggest we just change the old repo to being public.

@zmx27
Copy link
Collaborator Author

zmx27 commented Nov 4, 2025

I think that making srxplanargui itself public might be the best choice to allow for independent versioning of each of the packages, as well as possible reuse of the GUI features that srxplanargui provides to any other projects that we could have in the future.

@sbillinge
Copy link
Contributor

I think that making srxplanargui itself public might be the best choice to allow for independent versioning of each of the packages, as well as possible reuse of the GUI features that srxplanargui provides to any other projects that we could have in the future.

I agree, let's do that. Sorry for wasting your time there by mistake! Thanks for the patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants