Async track fetching when selecting playlist.#971
Open
cookiemonsternz wants to merge 4 commits intodigimezzo:masterfrom
Open
Async track fetching when selecting playlist.#971cookiemonsternz wants to merge 4 commits intodigimezzo:masterfrom
cookiemonsternz wants to merge 4 commits intodigimezzo:masterfrom
Conversation
Author
|
Just noticed an issue with this, if you select a playlist with one of these slow loading files and then select another playlist while it is still getting the tracks, it doesn't show the tracks from the currently selected playlist, instead showing those from the originally selected. I'll see about fixing this soon. |
Author
|
Alright; I've implemented a potentially quite hacky fix, which is to set a global flag while a playlist is fetching tracks and just wait for that to be false before starting on the next playlist fetch. I understand this is far from an ideal solution but I'm not entirely sure how to get a better working solution - any ideas would be greatly appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Dopamine freezing when selecting a playlist with many tracks, or with tracks in a location which takes a significant time to read. For example, if a file from the playlist is in an unavailable network drive, Dopamine completely freezes for approximately 2.5s.
The cause of the freezing is
fs.existsSync()viaPlaylistService.getTracksAsync()->PlaylistService.decodePlaylistAsync()->FileValidator.isPlayableAudioFile().Fix uses async method
fs.access()instead of the blockingfs.existsSync().Note that this also means that other functions reliant on
FileValidator.isPlayableAudioFile()will also freeze Dopamine in a similar case, so it is potentially worth swapping those to a different method as well.