Use Async streaming by default #25
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue overview
The current implementation of
_streamuses the syncGradientclient. Since no async streaming implementation is available, it causes async streams to still remain blocking under the hood.Additionally, this causes a bug when creating a streaming agent with the DigitalOcean Gradient ADK, where agents built with
langchain_gradientwill buffer their entire response instead of streaming.For a minimal reproducible example, follow the Gradient ADK example with the following code
Agent:
Client Side:
When using the ChatGradient client, the entire response is generated before being streamed out. Meanwhile with the OpenAI client, streaming occurs properly.
Fix Details
This PR fixes the incompatibility by using the async client within
_astreamand making async streaming non-blocking.