Datasets can have own width for strokes or disable it by setting it t…#24
Open
jannhama wants to merge 2 commits intodima117:masterfrom
Open
Datasets can have own width for strokes or disable it by setting it t…#24jannhama wants to merge 2 commits intodima117:masterfrom
jannhama wants to merge 2 commits intodima117:masterfrom
Conversation
dima117
reviewed
Aug 30, 2017
Owner
dima117
left a comment
dima117
left a comment
There was a problem hiding this comment.
Why do you use scatter chart plugin for chart.js v1 during chart.js v2 is exist and contains own scatter chart implementation?
| ctx.beginPath(); | ||
|
|
||
| helpers.each(dataset.points, function (point, index) { | ||
| if (dataset.strokeWidth==0) { |
Owner
There was a problem hiding this comment.
please invert this if to avoid multiple return points of the funciton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o zero
I added this feature to make possible to have chart with datapoints visible only. This is done by defining stroke width in datasets instead of global config parameters. I used this version in a chart with one dataset having datapoints + line and one dataset with datapoints only.