Resolve failure to read long file path #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes to realsync to open a pull request for wayfair
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently realsync gets caught in a loop when trying to copy over files that exceed the limit for file path/name length. What happens it realysync fails to copy the file, as expected. But then realsync, noticing that this file is in the source but not the destination, tries to copy the file over again so that source and destination are properly synced. Realsync is unable to copy the file over due to the file path/name length again and the cycle repeats.
The changes in this pull request allow realsync to fail gracefully when the file path/name is too long without trying to copy the file again.