Skip to content

Issue 1698: Do an OR search if namespace is local #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pjohans wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Issue 1698: Do an OR search if namespace is local #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/request/TingClientCollectionRequest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,15 @@ public function setAgency($agency) {
}

public function getRequest() {
$this->setQuery('rec.id=' . $this->id);
$id_array[] = $this->id;
Copy link
Member

@cableman cableman Jun 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This array is not used in the code?

if(strpos($this->id, $this->agency.'-katalog') !== FALSE) {
list($owner, $id) = explode(':', $this->id);
$this->setQuery('rec.id=870970-basis:' . $id . ' OR rec.id=' . $this->id);
Copy link

@xendk xendk Jun 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be commented as to why.

If the id is in the local catalog, it adds a search for basis:id? Why? And what if both exists?

}
else{
$this->setQuery('rec.id=' . $this->id);
}

$this->setAgency($this->agency);
$this->setAllObjects(true);
$this->setNumResults(1);
Expand Down