{Sponsored by Intelliterra} OPEN_DRONE_ID_SYSTEM, OPEN_DRONE_ID_SELF_ID, and OPEN_DRONE_ID_OPERATOR_ID values getting cached within PX4#1
Merged
dirksavage88 merged 8 commits intodirksavage88:remote_id_armfrom Jul 7, 2023
Conversation
dirksavage88
reviewed
Jul 7, 2023
dirksavage88
reviewed
Jul 7, 2023
dirksavage88
reviewed
Jul 7, 2023
dirksavage88
reviewed
Jul 7, 2023
Owner
dirksavage88
left a comment
dirksavage88
left a comment
There was a problem hiding this comment.
Looks good so far, just minor stuff that needs a closer look
jnomikos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sponsored by Intelliterra
Solved Problem
OPEN_DRONE_ID_SYSTEM, OPEN_DRONE_ID_BASIC_ID, and OPEN_DRONE_ID_OPERATOR_ID values were not being cached within PX4 when received from QGC.
Note: I have not tested OPEN_DRONE_ID_SYSTEM yet as I have not been able to arm.
OPEN_DRONE_ID_OPERATOR_ID is sending data through the cube ID, and it is showing up on the Drone Scanner app. The drone scanner app gives the warning "Invalid Data", but is displaying the data correctly.
OPEN_DRONE_ID_SELF_ID is showing up on the Drone Scanner app on "Operator Description" and is showing character numbers rather than actual characters. Might be a bug on that app itself.
Context
PX4#21777
PX4#21647