Skip to content
This repository was archived by the owner on Feb 18, 2025. It is now read-only.

display error in test when vm crashes #64

Open
wants to merge 4 commits into
base: topic/windows-ffi
Choose a base branch
from
Open

display error in test when vm crashes #64

wants to merge 4 commits into from

Conversation

@soloturn
Copy link

@soloturn soloturn commented Oct 24, 2024 •
edited
Loading

display error in test when vm crashes, not fork makes it easier. also run github workflow with test on every branch and push to let dev know immediate about other operating systems.

see this run: https://github.com/soloturn/directories-jvm/actions/runs/11490416374/job/31981080185 as an example how it looks likke.

[info] done compiling
[error] Test dev.dirs.impl.UtilTest.testWindowsApplicationPath01 failed: java.lang.NoClassDefFoundError: Could not initialize class dev.dirs.impl.Windows, took 1.556 sec
[error] Test dev.dirs.DirectoriesTest.testUserDirectories failed: java.lang.UnsatisfiedLinkError: D:\a\directories-jvm\directories-jvm\target\task-temp-directory\sbt_81103506\sbt_16d447[19](https://github.com/soloturn/directories-jvm/actions/runs/11490416374/job/31981080185#step:4:20)\combase.dll: A dynamic link library (DLL) initialization routine failed, took 1.561 sec
[error]     at dev.dirs.impl.UtilTest.testWindowsApplicationPath01(UtilTest.java:125)
...

brcolow and others added 3 commits October 21, 2024 19:48
@brcolow @soc
Use Java 22's foreign function API for Windows
fcf0332 
- Drop all existing mechanisms for retrieving this info on Windows
- This increases the required Java version of the library to 22

Fixes dirs-dev#49.
@soloturn
disable fork test to see real error
61e34c9
@soloturn
run github workflow on all branches
bd7b7c5
@soloturn soloturn mentioned this pull request Oct 24, 2024
Merged
@soloturn
Copy link
Author

updated with @FriendSeekers suggestion, now test passes:
https://github.com/soloturn/directories-jvm/actions/runs/11537039421

@soc soc force-pushed the topic/windows-ffi branch from fcf0332 to 50ce28c Compare November 7, 2024 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@soloturn @brcolow