Skip to content

Conversation

@MinnDevelopment
Copy link
Member

@MinnDevelopment MinnDevelopment commented Dec 28, 2025

Pull Request Etiquette

  • I have checked the PRs for upcoming features/bug fixes.
  • I have read the contributing guidelines.
  • I applied the code formatter to my changes with ./gradlew format

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: #2816

Description

This adds support for third-party implementations of the DAVE protocol. All implementations of DAVE must be provided by the user. JDA will not have its own implementation of this protocol, to improve flexibility. We are moving towards an opt-in audio module.

I'm currently working on an implementation using Java's FFM API, which will require Java 25. Other implementations that use JNI to provide support for other Java versions are naturally also welcome.

Example - JDAVE

Here is a minimal example with JDAVE:

JDABuilder.createLight(TOKEN)
  .setAudioModuleConfig(new AudioModuleConfig()
    .withDaveSessionFactory(new JDaveSessionFactory()))
  .build()
dependencies {
    implementation("club.minnced:jdave-native-linux-x86-64:0.0.1")
}

@MinnDevelopment MinnDevelopment force-pushed the feature/dave branch 2 times, most recently from 88b4925 to d1b2e60 Compare December 30, 2025 12:44
@MinnDevelopment MinnDevelopment changed the title Add support for libdave (WIP) Add support for libdave Dec 30, 2025
@MinnDevelopment MinnDevelopment marked this pull request as ready for review December 30, 2025 15:49

This comment was marked as resolved.

This comment was marked as resolved.

Copy link

@construktdev construktdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's good to me

@MinnDevelopment MinnDevelopment added this pull request to the merge queue Jan 7, 2026
Merged via the queue into master with commit 0b11f1a Jan 7, 2026
1 check passed
@MinnDevelopment MinnDevelopment deleted the feature/dave branch January 7, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants