-
-
Notifications
You must be signed in to change notification settings - Fork 758
Add support for libdave #2988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add support for libdave #2988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88b4925 to
d1b2e60
Compare
1fec586 to
8bf3cd5
Compare
89bd530 to
41167ad
Compare
2cabef0 to
e6c31f7
Compare
construktdev
reviewed
Jan 7, 2026
construktdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look's good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
./gradlew formatChanges
Closes Issue: #2816
Description
This adds support for third-party implementations of the DAVE protocol. All implementations of DAVE must be provided by the user. JDA will not have its own implementation of this protocol, to improve flexibility. We are moving towards an opt-in audio module.
I'm currently working on an implementation using Java's FFM API, which will require Java 25. Other implementations that use JNI to provide support for other Java versions are naturally also welcome.
Example - JDAVE
Here is a minimal example with JDAVE: