fix: disable CA animations during modal presentation#7
Open
SzymczakJ wants to merge 1 commit intodiscord-4.23.0from
Open
fix: disable CA animations during modal presentation#7SzymczakJ wants to merge 1 commit intodiscord-4.23.0from
SzymczakJ wants to merge 1 commit intodiscord-4.23.0from
Conversation
…ation Add logging to track modal presentation lifecycle and disable CoreAnimation actions during mounting transactions when a modal presentation is in progress to prevent unintended animation artifacts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_rnsModalPresentationInProgressto track when a modal is being presentedCATransaction setDisableActions:YES) during mounting transactions while a modal presentation is in progress, preventing unintended animation artifacts[kubson]prefix) to trace modal presentation lifecycle and mounting transaction timingTest plan
[kubson]entries🤖 Generated with Claude Code