Skip to content

Conversation

@diskshima
Copy link
Owner

Summary

This PR cleans up the code following the migration to optparse-applicative in PR #90. The changes improve code organization and maintainability without affecting functionality.

Changes

  • Renamed NewCommandLineParser to CommandLineParser: The new parser module now has its proper final name
  • Removed old CommandLineParser module: Deleted the obsolete GetOpt-based parser that was replaced
  • Cleaned up Main.hs:
    • Removed obsolete comments (e.g., "Old...", "Refactored...", "TODO...")
    • Removed commented-out imports
    • Improved code formatting and consistency
    • Removed unnecessary blank lines
  • Updated gwcli.cabal: Removed NewCommandLineParser from exposed modules list

Testing

  • ✅ Project builds successfully with cabal build
  • ✅ All existing functionality preserved
  • ✅ No breaking changes

Related

Closes cleanup tasks from #90

🤖 Generated with Claude Code

This commit cleans up the code after the migration to optparse-applicative:

- Rename NewCommandLineParser to CommandLineParser
- Remove old GetOpt-based CommandLineParser module
- Clean up Main.hs by removing obsolete comments and dead code
- Update gwcli.cabal to reflect module name changes
- Improve code formatting and consistency

All changes maintain backward compatibility while improving code readability
and maintainability.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@diskshima
Copy link
Owner Author

Closing this PR in favor of stacked PRs #93 and #94 for better separation of concerns (cabal config vs code cleanup)

@diskshima diskshima closed this Oct 11, 2025
@diskshima diskshima deleted the cleanup-pr90-parser-migration branch October 11, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant