Open
Conversation
rahzbob
force-pushed
the
feature/detail_panel_select
branch
2 times, most recently
from
208bca2 to
18e3cf4
Compare
rahzbob
force-pushed
the
feature/detail_panel_select
branch
2 times, most recently
from
a6ddbc1 to
0cbe482
Compare
rahzbob
requested review from
Zorin95670,
aboubakar14,
justinehell,
k-y0u and
mumpkin
and removed request for
Zorin95670 and
k-y0u
justinehell
force-pushed
the
feature/detail_panel_select
branch
from
0cbe482 to
95a4a95
Compare
justinehell
requested changes
Sep 13, 2023
| /** | ||
| * Initialize the options for the select. | ||
| */ | ||
| function initOptions() { |
|
|
||
| options.value = [{ | ||
| type: 'category', | ||
| name: 'default', |
| })), | ||
| }, { | ||
| type: 'category', | ||
| name: 'variable', |
justinehell
force-pushed
the
feature/detail_panel_select
branch
from
95a4a95 to
d51cce5
Compare
Checking /home/runner/work/leto-modelizer/leto-modelizer/package.json
@quasar/app-webpack =3.9.6 → =3.11.0
cypress =12.17.4 → =13.2.0
monaco-editor =0.41.0 → =0.43.0
quasar =2.12.6 → =2.12.7
Run npx npm-check-updates -x leto-modelizer* -u to upgrade package.json |
|
Kudos, SonarCloud Quality Gate passed! |
aboubakar14
reviewed
Sep 18, 2023
| :key="child.name" | ||
| :item="child" | ||
| class="item-list" | ||
| @select-item="(value) => $emit('select-item', value)" |
Member
There was a problem hiding this comment.
I would put something more specific than 'select-name' as the event name, maybe "'item-clicked" or something like that
src/components/inputs/ArrayInput.vue
Outdated
| const variables = ref(plugin.value.data.variables || []); | ||
|
|
||
| /** | ||
| * Initialize the options for the select. |
Member
There was a problem hiding this comment.
Could you be a little more specific about the description ? Specially about the "for the select"
src/components/inputs/LinkInput.vue
Outdated
| /** | ||
| * Initialize the options for the select. | ||
| */ | ||
| function initOptions() { |
Member
There was a problem hiding this comment.
already used 3times. I would rather put this in some kind of utility file and import this function in the component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #305