Skip to content

fix ios tabs#6

Open
nice77 wants to merge 1 commit intodivkit:mainfrom
nice77:fix/ios-tabs
Open

fix ios tabs#6
nice77 wants to merge 1 commit intodivkit:mainfrom
nice77:fix/ios-tabs

Conversation

@nice77
Copy link
Copy Markdown

@nice77 nice77 commented Apr 3, 2026

No description provided.

@rsbooster
Copy link
Copy Markdown
Collaborator

Hi.
Thanks for pull request.
Unfortunately, I was not able to reproduce problem with tabs switching glitch on any tests that we have.
For example tabs_with_dynamic_height or div_tabs.json.
Could you please provide json or specify additional prerequisites for bug reproducing.

@nice77
Copy link
Copy Markdown
Author

nice77 commented Apr 4, 2026

Hi!
I've prepared a sample: https://gist.github.com/nice77/de5b9198216dc81674a991367ed61e5a
DivKit version: 32.26.0
iOS: 18.6 (if relevant)

I've also attached screencasts. The first one shows my sample JSON reproducing bizarre behavior, and the second one shows div_tabs.json

2026-04-05.02.16.35.mov
2026-04-05.02.19.21.mov

@nice77
Copy link
Copy Markdown
Author

nice77 commented Apr 5, 2026

I tried to compare two layouts; the issue with switching tabs is happening only when we're using "type": "gallery" inside of a item builder, instead of using "type": "container". Here's my sample with changed type: https://gist.github.com/nice77/309111b7502fb1b60553bc5728aeda41

@nice77
Copy link
Copy Markdown
Author

nice77 commented Apr 6, 2026

@rsbooster, did you receive my updates? Any feedback would be appreciated

@rsbooster
Copy link
Copy Markdown
Collaborator

@rsbooster, did you receive my updates? Any feedback would be appreciated

Yes, thanks a lot.
Now I can reproduce the problem.
I will check couple edge cases today and If everything goes well, we'll merge the PR.

@rsbooster
Copy link
Copy Markdown
Collaborator

@nice77 please adopt Yandex Contributor License Agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants