Skip to content

disallow nSequence values without consensus meaning wrt BIP-68 #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scgbckbone wants to merge 1 commit into
base: master
Choose a base branch
from
Open

disallow nSequence values without consensus meaning wrt BIP-68 #104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions src/embit/descriptor/miniscript.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,15 +160,15 @@ def __len__(self):
return self.len_args() + 3


class Older(OneArg):
# <n> CHECKSEQUENCEVERIFY
NAME = "older"
class After(OneArg):
# <n> CHECKLOCKTIMEVERIFY
NAME = "after"
ARGCLS = Number
TYPE = "B"
PROPS = "z"

def inner_compile(self):
return self.carg + b"\xb2"
return self.carg + b"\xb1"

def verify(self):
super().verify()
Expand All @@ -181,12 +181,28 @@ def __len__(self):
return self.len_args() + 1


class After(Older):
# <n> CHECKLOCKTIMEVERIFY
NAME = "after"
class Older(After):
# <n> CHECKSEQUENCEVERIFY
NAME = "older"

def inner_compile(self):
return self.carg + b"\xb1"
return self.carg + b"\xb2"

def verify(self):
super().verify()
# https://github.com/bitcoin/bitcoin/pull/33135 older(65536) is equivalent to older(1)
if self.arg.num & (1 << 22):
# time-based
if (self.arg.num < 0x400001) or (self.arg.num >= 0x410000):
raise MiniscriptError(
"Time-based %s should have an argument in range [0x400001, 0x410000)" % self.NAME
)
else:
# block-based
if self.arg.num >= 0x10000:
raise MiniscriptError(
"Block-based %s should have an argument in range [1, 0x10000)" % self.NAME
)


class Sha256(OneArg):
Expand Down