Skip to content

Miniscript - t Wrapper Verifies if Fragment Type is V #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
odudex wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Miniscript - t Wrapper Verifies if Fragment Type is V #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/embit/descriptor/miniscript.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,6 +870,11 @@ def inner_compile(self):

def __len__(self):
return len(self.arg) + 1

def verify(self):
super().verify()
if self.arg.type != "V":
raise MiniscriptError("t: X must be of type V")

@property
def properties(self):
Expand Down
8 changes: 8 additions & 0 deletions tests/tests/test_descriptor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,14 @@ def test_miniscript_compat(self):
for desc in generalistic_descs:
Descriptor.from_string(desc)

def test_invalid_miniscript(self):
"""Ensure an error is raised when parsing invalid miniscript"""
invalid_descs = [
"wsh(ttvtvtvtvtvtvtv:after(230775))",
]
for desc in invalid_descs:
self.assertRaises(MiniscriptError, Descriptor.from_string, desc)

def test_len(self):
"""Checks that len(miniscript) returns correct length"""
for op in OPERATORS:
Expand Down