Skip to content

Conversation

@herra
Copy link

@herra herra commented Mar 24, 2020

Blockers

  • popper missing dep
  • display point tasks (zero-length) in history
  • missing app.css
  • (history) increase size for left axis labels (not to be cut)
  • (history) display dates in bottom axis
  • (history) show multiple subtasks as a single labeled row
  • (history) render each end of day
  • (history) tooltip is hard to show on point tasks - they show start time on current implementation
  • (tasks) show current page in tasks paginator (Fix pagination #55)
  • (tasks) pagination doesn't work (Fix pagination #55)
  • (history) show failed&running in different color (need status in history.json)
  • (history) first zoom-in on history chart does zoom-out
  • (history) show current time of day line in history chart

High priority

medium

  • handle connectivity issues in history page
  • zoom in to area/task in history chart
  • autoupdate history chart
  • refactor pagination api
  • explicit dependencies (component requires components it uses - maybe using the name for more explicitness)
  • sass for components
  • display spinner on loading messages
  • cancel running task

Points to discuss:

  • js requires building

@lgtm-com
Copy link

lgtm-com bot commented Mar 27, 2020

This pull request fixes 2 alerts when merging 8ff6276 into 639070b - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Mar 27, 2020

This pull request fixes 2 alerts when merging 547eb02 into 639070b - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 19, 2020

This pull request fixes 2 alerts when merging 9386798 into 008f424 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 19, 2020

This pull request fixes 2 alerts when merging 73994c6 into 008f424 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 19, 2020

This pull request fixes 2 alerts when merging 9d62edf into 008f424 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 20, 2020

This pull request fixes 2 alerts when merging c13683e into 98ddd5f - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 20, 2020

This pull request fixes 2 alerts when merging aad6345 into 98ddd5f - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 20, 2020

This pull request fixes 2 alerts when merging 7b229ad into 98ddd5f - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 20, 2020

This pull request fixes 2 alerts when merging b6f30fc into 98ddd5f - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 20, 2020

This pull request fixes 2 alerts when merging c8587ca into 98ddd5f - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 20, 2020

This pull request fixes 2 alerts when merging 5d00694 into 98ddd5f - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 21, 2020

This pull request fixes 2 alerts when merging 69f0b01 into b35329c - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@groupsky groupsky requested review from a team and i-trofimtschuk and removed request for a team May 27, 2020 10:29
@lgtm-com
Copy link

lgtm-com bot commented May 27, 2020

This pull request introduces 1 alert and fixes 2 when merging 5baae40 into bbe3317 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request fixes 2 alerts when merging 80b6f1f into bbe3317 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request fixes 2 alerts when merging ed39856 into bbe3317 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request fixes 2 alerts when merging 2cf61b7 into bbe3317 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

groupsky added 3 commits May 29, 2020 09:20
In some cases component is not yet upgraded in connected callback. This adds a whenUpgraded(node) that is resolved once the component is registered and upgraded.
Available in dev server as http://localhost:8080/history.html - allows easier preview of history chart.
@lgtm-com
Copy link

lgtm-com bot commented May 29, 2020

This pull request fixes 2 alerts when merging 8012a85 into 0604e52 - view on LGTM.com

fixed alerts:

  • 1 for Useless assignment to local variable
  • 1 for Unused variable, import, function or class

@groupsky groupsky marked this pull request as draft June 29, 2020 10:09
@i-trofimtschuk i-trofimtschuk removed their request for review October 19, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants