Skip to content

Conversation

@herra
Copy link

@herra herra commented Mar 23, 2020

From:
image

To:
image

@i-trofimtschuk
Copy link
Member

@herra can you merge current master so tests can run (we just fixed master)

@i-trofimtschuk
Copy link
Member

screenshots look great!

@i-trofimtschuk i-trofimtschuk requested a review from a team March 26, 2020 11:47
@Chronial
Copy link
Contributor

The old positioning is correct for ston – that's why that negative margin was there.

@i-trofimtschuk
Copy link
Member

we should probably supply default admin compatible version here
and override the template in the using projects where custom admin styles are used

@i-trofimtschuk i-trofimtschuk requested review from a team and i-trofimtschuk and removed request for a team and i-trofimtschuk March 27, 2020 12:32
@i-trofimtschuk
Copy link
Member

we should probably supply default admin compatible version here
and override the template in the using projects where custom admin styles are used

@vasilty what do you think about ☝️

@kaloyanm
Copy link

kaloyanm commented Apr 1, 2020

@herra Can you check ston and see of this margin fix can be moved there?

@i-trofimtschuk
Copy link
Member

@vasilty can we move the ston-specific css rules to ston repo ?

@i-trofimtschuk
Copy link
Member

BTW @herra merging master should make tests pass again

@vasilty
Copy link
Member

vasilty commented Apr 1, 2020

that's reasonable to move ston styles to ston

@herra herra force-pushed the feature/fix-ui-look branch from e5059ff to 461b480 Compare April 1, 2020 20:20
@i-trofimtschuk
Copy link
Member

@vasilty @LutherEngelsnot you'd need to coordinate the release of ston styles with the new rt-dashboard version
maybe you can already add the removed styles to ston specific styles so they're "doubled" and the removal on upgrade won't break anything

@vasilty
Copy link
Member

vasilty commented Apr 2, 2020

Alternatively, we can add the styles in ston when upgrading rt-dashboard, which will make it clear in the git history why the change was made

@groupsky groupsky marked this pull request as draft June 29, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants