Conversation
djc
reviewed
Dec 18, 2024
src/extensions/change_poll.rs
Outdated
|
|
||
| impl Transaction<ChangePoll<'_>> for Poll {} | ||
| // todo: make sure no element for <extension> is added in the request when using this. | ||
| #[derive(Debug, FromXml, ToXml)] |
Owner
There was a problem hiding this comment.
Can we skip the ToXml derives for these types?
Contributor
Author
There was a problem hiding this comment.
I also removed the FromXml from the current stub type that implements Extension.
Owner
There was a problem hiding this comment.
I still see a bunch of types in the module that implement ToXml, is that necessary?
Contributor
Author
There was a problem hiding this comment.
No. Will take care of it tomorrow.
valkum
force-pushed
the
change-poll-fix
branch
2 times, most recently
from
ce23c3f to
1cb5469
Compare
There is no need for Cow as this is only deserialized and xml::deserialize uses FromXmlOwned.
valkum
force-pushed
the
change-poll-fix
branch
from
1cb5469 to
4320492
Compare
djc
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need for
Cowas this is only deserialized andxml::deserializeusesFromXmlOwned.This is still not working properly, as you cannot construct
RequestData(which enables the deserialization of the ChangePoll struct) without RequestData being serialized with<extension>tags. See #67.