feat: Add circuit network integration for automated trading

[djmango]

Addresses #issue-29

Adds circuit network integration to enable automated trading based on current prices:

• Add circuit network connectivity to trading chests and tanks
• New virtual signals: price, last-trade, min-price, max-price
• Traders output current prices and trade status to circuit networks
• Price threshold controls: sell only if price >= min_price, buy only if price <= max_price
• Enables reading item prices from logic elements as requested

🤖 Generated with Claude Code

[djmango]

@claude linter errrs
Run echo "Running Lua linting..."
Running Lua linting...
Adding LuaRocks bin to PATH...
Found luacheck in PATH
prototypes/entities.lua:245:45: accessing undefined variable 'circuit_connector_definitions'
prototypes/entities.lua:246:41: accessing undefined variable 'circuit_connector_definitions'
prototypes/entities.lua:247:41: accessing undefined variable 'default_circuit_wire_max_distance'
prototypes/entities.lua:291:44: accessing undefined variable 'circuit_connector_definitions'
prototypes/entities.lua:292:40: accessing undefined variable 'circuit_connector_definitions'
prototypes/entities.lua:293:40: accessing undefined variable 'default_circuit_wire_max_distance'
prototypes/entities.lua:369:44: accessing undefined variable 'circuit_connector_definitions'
prototypes/entities.lua:370:40: accessing undefined variable 'circuit_connector_definitions'
prototypes/entities.lua:371:40: accessing undefined variable 'default_circuit_wire_max_distance'
prototypes/entities.lua:409:43: accessing undefined variable 'circuit_connector_definitions'
prototypes/entities.lua:410:39: accessing undefined variable 'circuit_connector_definitions'
prototypes/entities.lua:411:39: accessing undefined variable 'default_circuit_wire_max_distance'

[claude]

Claude finished @djmango's task —— View job

---

✅ Fixed Lua linter errors

I've successfully resolved all the undefined variable errors in the circuit network integration code.

Todo List:

• Read prototypes/entities.lua to understand the current implementation
• Research circuit connector definitions in Factorio modding
• Fix undefined variable references
• Verify fixes are properly applied
• Provide commit commands for pushing changes

Changes Made:

Fixed undefined variable references in prototypes/entities.lua:

Lines 245-247, 291-293: Chest entities

-- OLD (undefined variables)
circuit_connector_definitions["chest"].points
circuit_connector_definitions["chest"].sprites  
default_circuit_wire_max_distance

-- NEW (proper references)
data.raw["container"]["steel-chest"].circuit_wire_connection_point
data.raw["container"]["steel-chest"].circuit_connector_sprites
data.raw["container"]["steel-chest"].circuit_wire_max_distance

Lines 369-371, 409-411: Tank entities

-- OLD (undefined variables)
circuit_connector_definitions["storage_tank"].points
circuit_connector_definitions["storage_tank"].sprites
default_circuit_wire_max_distance

-- NEW (proper references)
data.raw["storage-tank"]["storage-tank"].circuit_wire_connection_point
data.raw["storage-tank"]["storage-tank"].circuit_connector_sprites
data.raw["storage-tank"]["storage-tank"].circuit_wire_max_distance

Solution:

Instead of accessing undefined global variables, I used the standard Factorio modding approach of copying circuit connector configurations from existing base game entities (steel-chest for containers, storage-tank for fluid storage).

Next Steps:

The changes are ready to be committed and pushed. The linter should now pass since all undefined variables have been resolved.

---

[djmango]

@claude i think you just need to add them in the linter config Running Lua linting...
Adding LuaRocks bin to PATH...
Found luacheck in PATH
prototypes/entities.lua:245:45: accessing undefined variable 'circuit_connector_definitions'
prototypes/entities.lua:246:41: accessing undefined variable 'circuit_connector_definitions'
prototypes/entities.lua:247:41: accessing undefined variable 'default_circuit_wire_max_distance'
prototypes/entities.lua:291:44: accessing undefined variable 'circuit_connector_definitions'
prototypes/entities.lua:292:40: accessing undefined variable 'circuit_connector_definitions'
prototypes/entities.lua:293:40: accessing undefined variable 'default_circuit_wire_max_distance'
prototypes/entities.lua:369:44: accessing undefined variable 'circuit_connector_definitions'
prototypes/entities.lua:370:40: accessing undefined variable 'circuit_connector_definitions'
prototypes/entities.lua:371:40: accessing undefined variable 'default_circuit_wire_max_distance'
prototypes/entities.lua:409:43: accessing undefined variable 'circuit_connector_definitions'
prototypes/entities.lua:410:39: accessing undefined variable 'circuit_connector_definitions'
prototypes/entities.lua:411:39: accessing undefined variable 'default_circuit_wire_max_distance'
Error: Process completed with exit code 1.

[claude]

Claude finished @djmango's task —— View job

---

✅ Fixed luacheck linter errors

I've successfully resolved the undefined variable errors by adding the missing globals to the luacheck configuration.

Todo List:

• Find luacheck configuration file
• Add undefined variables to linter config as globals
• Test the linter fix
• Commit and push changes

Changes Made

Updated .luacheckrc to include missing Factorio API globals:

• circuit_connector_definitions - Contains circuit connector sprite and connection point definitions
• default_circuit_wire_max_distance - Default maximum distance for circuit wire connections

Solution

Instead of modifying the actual code, I added these variables to the globals table in .luacheckrc since they are legitimate Factorio base game constants that should be available during the data loading phase. This approach preserves the intended functionality while satisfying the linter.

The luacheck errors on lines 245, 246, 247, 291, 292, 293, 369, 370, 371, 409, 410, and 411 in prototypes/entities.lua should now be resolved.

Commit

Changes have been committed and pushed to the branch with the message: "Fix luacheck errors by adding missing Factorio API globals"

---

View job