Skip to content

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Nov 4, 2017

With DUB 1.6.0 (part of the DMD 2.077.0 release), DUB will retry
downloads from the DUB registry and alternatively use fallback mirrors.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach
Copy link
Contributor Author

wilzbach commented Dec 3, 2017

core.exception.RangeError@/home/dtest/DAutoTest/work/home/.dub/packages/ddox-0.15.18/ddox/source/ddox/parsers/jsonparser.d(469): Range violation
----------------
??:? _d_arrayboundsp [0x9de042]

so that error comes from the outdated ddox version which we use. Upgrading ddox to 0.16 solves this, but sadly we are blocked on this #1891 :/

@CyberShadow
Copy link
Member

Why are we not using the DMD we just built to build the docs from the master branches of other components?

With DUB 1.6.0 (part of the DMD 2.077.0 release), DUB will retry
downloads from the DUB registry and alternatively use fallback mirrors.
@wilzbach wilzbach force-pushed the bump-dmd-dub-version branch from 74f7bf1 to 1e31d4b Compare December 27, 2017 22:04
@wilzbach wilzbach removed the Blocked label Dec 27, 2017
@wilzbach
Copy link
Contributor Author

Why are we not using the DMD we just built to build the docs from the master branches of other components?

Because I think Martin wanted to lock the DMD version (?)
I'm more than happy to drop the download of DMD_STABLE if we can do so, but for now we can finally do this simple bump. With this bump we will upgrade DUB to 1.6.0 which contains a mirror of code.dlang.org. Thus this will hopefully result in less random failures on DAutoTest...

@wilzbach
Copy link
Contributor Author

wilzbach commented Dec 27, 2017

Example of the changes:

-								<code class="prettyprint lang-d"><span class="kwd">immutable</span><span class="pun">(</span><span class="pln">std<wbr/></span><span class="pun">.</span><span class="pln">typecons</span><span class="pun">[]</span><span class="pun">)</span></code>
+								<code class="prettyprint lang-d"><span class="kwd">immutable</span><span class="pun">(</span><a href="../std/typecons/tuple.html"><span class="typ">Tuple</span></a>!(std.encoding.BOM,"schema",ubyte[],"sequence")<span class="pun">[]</span><span class="pun">)</span></code>
 							</td>
 							<td>Mapping of a byte sequence to <b>Byte Order Mark (BOM)</b>
 </td>
@@ -2428,7 +2428,7 @@ matching <code class="lang-d"><a href="../std/encoding/bom_seq.html"><span class
 								</a>
 							</td>
 							<td>
-								<code class="prettyprint lang-d"><span class="pln">std<wbr/></span><span class="pun">.</span><span class="pln">typecons</span></code>
+								<code class="prettyprint lang-d"><a href="../std/typecons/tuple.html"><span class="typ">Tuple</span></a>!(std.encoding.BOM,"schema",ubyte[],"sequence")</code>
 							</td>
 							<td>The type stored inside <code class="lang-d"><a href="../std/encoding/bom_table.html"><span class="pln">bomTable</span></a></code>.
 </td>
-				<span class="kwd">abstract override </span>{null} <span class="pln">toString
-				<span class="pun">()</span><span class="pun">;</span>
+				<span class="kwd">abstract override </span><span class="typ">string</span> <span class="pln">toString
+				<span class="pun">()</span><span class="pln"> </span><span class="kwd">scope @safe const</span><span class="pun">;</span>

So yeah, we should really use master/stable (aka latest release) in the future

Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the diff, it is clear that this update makes a very solid improvement, for example:

Before:

image

After:

image

@dlang-bot dlang-bot merged commit f2df5ad into dlang:master Dec 28, 2017
@PetarKirov
Copy link
Member

For the most part, the improvements are across the board, though there were some regressions, e.g.:

diff --git a/web/library-prerelease/symbols.js b/web/library-prerelease/symbols.js
index 3dbabc3..d816765 100644
--- a/web/library-prerelease/symbols.js
+++ b/web/library-prerelease/symbols.js
@@ -5675,7 +5675,7 @@ var symbols = [
 {name: 'core.thread.Fiber.State.HOLD', kind: "enummemberdeclaration", path: './core/thread/fiber.state.html#HOLD', attributes: []},
 {name: 'core.thread.Fiber.State.TERM', kind: "enummemberdeclaration", path: './core/thread/fiber.state.html#TERM', attributes: []},
 {name: 'core.thread.Fiber.state', kind: "functiondeclaration", path: './core/thread/fiber.state.html', attributes: ["final", "pure", "nothrow", "property", "nogc", "safe", "const"]},
-{name: 'core.thread.Fiber.this', kind: "functiondeclaration", path: './core/thread/fiber.this.html', attributes: ["nothrow"]},
+{name: 'core.thread.Fiber.this', kind: "functiondeclaration", path: './core/thread/fiber.this.html', attributes: []},
 {name: 'core.thread.Fiber.yield', kind: "functiondeclaration", path: './core/thread/fiber.yield.html', attributes: ["static", "nothrow", "nogc"]},
 {name: 'core.thread.Fiber.yieldAndThrow', kind: "functiondeclaration", path: './core/thread/fiber.yield_and_throw.html', attributes: ["static", "nothrow", "nogc"]},
 {name: 'core.thread.fiber_switchContext', kind: "functiondeclaration", path: './core/thread/fiber_switch_context.html', attributes: ["nothrow", "nogc"]},
@@ -5710,7 +5710,7 @@ var symbols = [
 {name: 'core.thread.Thread.PRIORITY_MAX', kind: "functiondeclaration", path: './core/thread/thread.priorit_y_max.html', attributes: ["static", "pure", "nothrow", "property", "nogc", "trusted"]},
 {name: 'core.thread.Thread.PRIORITY_MIN', kind: "functiondeclaration", path: './core/thread/thread.priorit_y_min.html', attributes: ["static", "pure", "nothrow", "property", "nogc", "trusted"]},
 {name: 'core.thread.Thread.sleep', kind: "functiondeclaration", path: './core/thread/thread.sleep.html', attributes: ["static", "nothrow", "nogc"]},
-{name: 'core.thread.Thread.start', kind: "functiondeclaration", path: './core/thread/thread.start.html', attributes: ["final", "nothrow"]},
+{name: 'core.thread.Thread.start', kind: "functiondeclaration", path: './core/thread/thread.start.html', attributes: ["final"]},

For some unknown reason to me, the nothrow attribute vanished.

@PetarKirov
Copy link
Member

PetarKirov commented Dec 28, 2017

Submitted issue: https://issues.dlang.org/show_bug.cgi?id=18137

@wilzbach wilzbach deleted the bump-dmd-dub-version branch December 28, 2017 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants