Skip to content

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Dec 5, 2017

Trying to push #1891 forward:

We could of course make a PR that runs the output through some HTML formatter (e.g. "tidy", which is included in the Debian repositories), once for the current version and once for the new one.

Let's see how good this works - locally I get a lot of warnings and errors with tidy :/

@wilzbach wilzbach added the WIP label Dec 5, 2017
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach wilzbach mentioned this pull request Dec 5, 2017
@CyberShadow
Copy link
Member

CyberShadow commented Dec 5, 2017

Guess I'll install tidy on k3 then.

Edit: Oh, this builds it from source. We probably don't want to do that for every website build though.

@wilzbach
Copy link
Contributor Author

wilzbach commented Dec 5, 2017

Edit: Oh, this builds it from source. We probably don't want to do that for every website build though.

Yep, I didn't know how responsive you were and also by building from source it should build on other Linux machines without interaction as well.
The idea was just to use Tidy during the ddox-0.15 -> ddox-0.16 transition, s.t. we can be sure that the diff is equal and that there are no hidden changes, but it looks like tidy isn't the best tool to work with the dirty HTML that DDoc and ddox produce:

Tidy found 88 warnings and 5163 errors! Not all warnings/errors were shown.

This document has errors that must be fixed before
using HTML Tidy to generate a tidied up version.

(see the log for more details)

@wilzbach
Copy link
Contributor Author

but it looks like tidy isn't the best tool to work with the dirty HTML that DDoc and ddox produce Tidy found 88 warnings and 5163 errors!

I guess this approach isn't going anywhere. Let's focus on fixing the bug in ddox (-> #1891 (comment)).

@wilzbach wilzbach closed this Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants