importC: fix issue #20410 #22056
importC: fix issue #20410 #22056
Conversation
|
Thanks for your pull request and interest in making D better, @Emmankoko! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
Emmankoko
force-pushed
the
id
branch
3 times, most recently
from
0e0118c to
5cad6d7
Compare
| version( Windows) | ||
| { | ||
| if (idx == "complex" || identx == "complex") |
There was a problem hiding this comment.
Where is the test for this? Why is this here?
| /* check for compiler builtins macros/ or specifier references. | ||
| * this is a workaround to avoid trying to resolve macros that | ||
| * reference other identifiers or functions | ||
| * so D users should avoid using custom macros beginning with __ | ||
| * to reference identifers |
There was a problem hiding this comment.
Why workaround? GDC knows what all these built-ins are so is not in the best interest to skip them.
There was a problem hiding this comment.
it ends up in a lot of undefined identifiers. especially when compiling druntime
3 participants
closes #20410
@dkorpel @thewilsonator