Skip to content

Conversation

@thewilsonator
Copy link
Contributor

No description provided.

@thewilsonator thewilsonator added the Review:Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org label Dec 6, 2025
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22196"

@thewilsonator thewilsonator force-pushed the with branch 3 times, most recently from cd09566 to 1564e7c Compare December 6, 2025 11:20
@dejlek
Copy link

dejlek commented Dec 6, 2025

Thank you for doing this!

@nordlow
Copy link
Contributor

nordlow commented Dec 8, 2025

At https://buildkite.com/dlang/dmd/builds/44260/steps/canvas?sid=019afb40-c8cd-49d1-9a18-a711b8b866c0 seems to be a conflict with the syntax

tests/unit_threaded/ut/integration.d(24,20): Error: found `(` while expecting `=` or identifier
    with(immutable Sandbox()) {
                   ^

. The caret position seems to be off.

@thewilsonator thewilsonator added the Review:Needs Changelog A changelog entry needs to be added to /changelog label Dec 13, 2025
@thewilsonator thewilsonator force-pushed the with branch 2 times, most recently from afe7ec0 to b5e6f5c Compare December 25, 2025 01:33
@thewilsonator thewilsonator force-pushed the with branch 2 times, most recently from d967279 to f1df11c Compare December 31, 2025 10:01
@thewilsonator thewilsonator removed the Review:Needs Changelog A changelog entry needs to be added to /changelog label Dec 31, 2025
@thewilsonator thewilsonator removed the Review:Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org label Dec 31, 2025
@dkorpel
Copy link
Contributor

dkorpel commented Dec 31, 2025

Did you fix the breakage issue?

@RazvanN7 RazvanN7 merged commit a2da514 into dlang:master Jan 5, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants