Skip to content

Fix #22813 - Removing __monitor from Object leads to errors#22817

Draft
dkorpel wants to merge 1 commit intodlang:masterfrom
dkorpel:no-monitor-typeinfo-size
Draft

Fix #22813 - Removing __monitor from Object leads to errors#22817
dkorpel wants to merge 1 commit intodlang:masterfrom
dkorpel:no-monitor-typeinfo-size

Conversation

@dkorpel
Copy link
Copy Markdown
Contributor

@dkorpel dkorpel commented Mar 26, 2026

Closes #22813

Need to check whether LDC and GDC use target.classinfosize

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22817"

@thewilsonator
Copy link
Copy Markdown
Contributor

LDC does not.

@thewilsonator
Copy link
Copy Markdown
Contributor

if (Type.typeinfoclass)
{
if (Type.typeinfoclass.structsize != target.classinfosize)
if (Type.typeinfoclass.structsize != cd.classInfoSize)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to account for monitor here as done in verifyStructSize?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removing __monitor from Object leads to errors

3 participants