Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Conversation

@JohanEngelen
Copy link
Contributor

The source path of many rt files is absent or broken. This fixes it for one file.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @JohanEngelen! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@dlang-bot dlang-bot added the Trivial typos, formatting, comments label Jan 17, 2018
@JohanEngelen JohanEngelen changed the title [trivial] Fix source path [trivial] Fix ddoc source path of rt_dmain2 Jan 17, 2018
Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good catch!

@wilzbach
Copy link
Contributor

Interestingly CircleCi fails consistently with:

****** FAIL debug64 core.time
core.exception.AssertError@src/core/time.d(527): unittest failure
----------------

Reproducible with:

TEST_COVERAGE=1 make -f posix.mak unittest-debug 

@wilzbach
Copy link
Contributor

The CircleCi failure is clearly unrelated and I am working at #2048 to fix it. However as #2048 has no clear direction except that a single line is responsible and all other CIs are happy with this - I am going to pull this. It just changes the Ddoc comment after all.

@wilzbach wilzbach merged commit cf41932 into dlang:master Jan 18, 2018
@JohanEngelen JohanEngelen deleted the patch-1 branch January 18, 2018 20:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants