Fix paths in benchmark runner #2050
Conversation
On osx I was getting a “No such file” exception for Dante.txt because CWD depended on where I executed `rdmd benchmark.d` from. And the object files were generated in a directory also depending on that. This fixes obj dir to same level as bin dir within the benchmarks dir, and allows the runCmd to take a workDir parameter for running the benchmark executables
|
Thanks for your pull request, @aliak00! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
| { | ||
| sw.reset; | ||
| auto output = runCmd(cmd, cfg.verbose); | ||
| auto output = runCmd(cmd, cfg.verbose, cwd); |
There was a problem hiding this comment.
Argh - I didn't see that cwd is already set to exactly this.
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
Looks reasonable to me.
|
CircleCi failure is unrelated - see #2048 for details. |
|
Sweet! Thanks 😄 |
4 participants
On osx I was getting a “No such file” exception for dante.txt
because CWD depended on where I executed
rdmd benchmark.dfrom.And the object files were generated in a directory also depending
on that.
This fixes obj dir to same level as bin dir within the benchmarks
dir, and allows the runCmd to take a workDir parameter for running
the benchmark executables