Reduce GC pressure to mitigate recent outages caused AI bots #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ludwig
changed the title
Geod24
approved these changes
Apr 17, 2025
Avoids transferring, allocating and converting parts of a package document, such as the per-version readme.
This is a considerable source for GC allocations. Disabling it will make JSON related error messages worse, but helps a lot in coping with the recent AI bot traffic.
In case the update takes more than 30 seconds, the existing approach would potentially lead to a complete lock-up of the process, since multiple runs of updatePackageList would start to overlap. This ensures that only one update can be active at a time and that there is always a time in-between where the thread is not busy with list updates.
s-ludwig
force-pushed
the
reduce_gc_pressure
branch
from
0210466 to
e5c6398
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some improvements to the amount of GC allocations used during normal operation. The shallow package list and
updatePackageListexecution changes are new changes, since the other changes only helped temporarily.See also: https://forum.dlang.org/thread/pnlyqzhuddbktbgyytxu@forum.dlang.org