Work On Issue 10828 - Add output range versions of toString functions to std.datetime.TimeOfDay #6071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your pull request, @JackStouffer! Bugzilla references
|
wilzbach
approved these changes
Jan 26, 2018
| formattedWrite(writer, "%02d%02d%02d", _hour, _minute, _second); | ||
| catch (Exception e) | ||
| assert(0, "format() threw."); | ||
| assert(0, "formattedWrite() threw."); |
Contributor
There was a problem hiding this comment.
Off-topic
FYI there's a trick to avoid the red coverage here - from dlang/druntime#2057 (comment):
scope (failure) assert(0, "formattedWrite() threw.");
formattedWrite(writer, "%02d%02d%02d", _hour, _minute, _second);Also I wonder whether formattedWrite can be made nothrow when the input string is passed in at CTFE and thus checked at compile-time.
Contributor
Author
There was a problem hiding this comment.
Contributor
|
BTW as you seem to be working on adding Writer support to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5991 and #6060 for more details