Skip to content

Fix Android Crash: #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hsangtini wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Android Crash: #605

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d517b77
Fix Android Crash:
hsangtini Aug 6, 2025
b4f4f41
Fix Android Crash:
hsangtini Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions android/src/main/kotlin/com/tundralabs/fluttertts/FlutterTtsPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,10 +216,11 @@ class FlutterTtsPlugin : MethodCallHandler, FlutterPlugin {

private val onInitListenerWithCallback: TextToSpeech.OnInitListener =
TextToSpeech.OnInitListener { status ->
// Handle pending method calls (sent while TTS was initializing)
// Safely handle any pending method calls sent while TTS was initializing.
synchronized(this@FlutterTtsPlugin) {
ttsStatus = status
for (call in pendingMethodCalls) {
// FIX 1: Iterate over a copy of the list to avoid ConcurrentModificationException.
for (call in pendingMethodCalls.toList()) {
call.run()
}
pendingMethodCalls.clear()
Expand All @@ -238,19 +239,28 @@ class FlutterTtsPlugin : MethodCallHandler, FlutterPlugin {
Log.e(tag, "getDefaultLocale: " + e.message)
}

engineResult!!.success(1)
// FIX 2: Only reply once per request to avoid "Reply already submitted" crash.
if (engineResult != null) {
engineResult!!.success(1)
engineResult = null // Mark as handled to prevent double-reply.
}
} else {
engineResult!!.error("TtsError","Failed to initialize TextToSpeech with status: $status", null)
// FIX 2: Only reply once per request to avoid "Reply already submitted" crash.
if (engineResult != null) {
engineResult!!.error("TtsError","Failed to initialize TextToSpeech with status: $status", null)
engineResult = null // Mark as handled to prevent double-reply.
}
}
//engineResult = null
// No need to set engineResult = null here; already handled above.
}

private val onInitListenerWithoutCallback: TextToSpeech.OnInitListener =
TextToSpeech.OnInitListener { status ->
// Handle pending method calls (sent while TTS was initializing)
// Safely handle any pending method calls sent while TTS was initializing.
synchronized(this@FlutterTtsPlugin) {
ttsStatus = status
for (call in pendingMethodCalls) {
// FIX 1: Iterate over a copy of the list to avoid ConcurrentModificationException.
for (call in pendingMethodCalls.toList()) {
call.run()
}
pendingMethodCalls.clear()
Expand Down